leggett / simplify-trackers Goto Github PK

First, huge thanks for sharing the tracker list! It would be useful if you could publish the js script as a package on npm for the ease of keeping the list updated as a consumer.

I'm getting regex compile warnings on regexes like

mail.[a-zA-Z0-9-.]+.pl\\/o\\/
email.[a-zA-Z0-9-.]+\\/o\\/[a-zA-Z0-9-_.]{64}

Ruby issues a warning when it compiles these:

warning: character class has '-' without escape:...

If I change the original regexes to

mail.[a-zA-Z0-9\\-.]+.pl\\/o\\/
email.[a-zA-Z0-9\\-.]+\\/o\\/[a-zA-Z0-9\\-_.]{64}

to escape the 'naked' dash, the regexes compile just fine. I'm pretty sure this is an artifact of JS that makes this legal but I just don't know for sure...

My question is: Are the second versions legal JS regexes?
My followup question is: Does this change alter the meanings of the original regexes?
My 2nd followup question would be: Which of the two versions are 'more correct™' ?

I'm not trying to start a JS vs Ruby flamewar here...just trying to make the awk script as robust as I can. I'm not a JS guy... So many languages...so little time...