GithubHelp home page GithubHelp logo

seobundle's Issues

$this->get is not a method in AbstractController

I am using Symfony 6.
When I try to add tags dynamically like this:

$this->get('leogout_seo.provider.generator')->get('basic')
            ->setTitle('Title set in controller')
            ->setRobots(true, false); // they can be chained

I get an error:

Attempted to call an undefined method named "get" of class "App\Controller\BlogController".
Did you mean to call "getSubscribedServices"?

I am following the documentation step by step.

Also tried with DI:

SeoGeneratorProvider $seo

But then I get:

The SEO generator with alias "leogout_seo.provider.generator" is not defined.

Add to basicTag

Hi i m'y looking to add MetaTag dynamique how i can do this ?

Generates "name" instead of "property"

The Facebook sharing debugger tool (https://developers.facebook.com/tools/debug/sharing/) gives me a warning about using "name" instead of "property" inside the générated metas, e.g. :

<meta name="og:image" content="..." /> should be <meta property="og:image" content="..." /> according to FB best practices on og tags.

Is there a way to modify this behaviour without modifying the bundle source code directly ?

SeoGeneratorPass::process return type

Currently getting a deprecation warning in Symfony 6.3. I've checked the branch for Symfony 7 and it won't actually cause a problem until Symfony 8.

Method "Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface::process()" might add "void" as a native return type declaration in the future. Do the same in implementation "Leogout\Bundle\SeoBundle\DependencyInjection\Compiler\SeoGeneratorPass" now to avoid errors or add an explicit @return annotation to suppress this message.

Adding the return type will break backwards compatibility, so perhaps this could be a 2.0 version when Symfony 8 is released, For now the @return annotation can be added. I'm happy to create a PR for the return annotation.

See https://symfony.com/blog/symfony-7-0-type-declarations for more details.

Warning on sf 5.2 - Seo generator services must be public.

Trying this bundle for my Symfony v5.2 (skeleton, not the web-skeleton) got an error

Seo generator services must be public, but "leogout_seo.generator.basic" is not.

it's happen for all generator (basic, og and twitter)

try setting for default, not working

services:
    _defaults:
        public: true

but, add public="true" in the service (seo/basic.xml) can solve the problem, but have no time try to the other major version of symfony.

More meta tags like pagination next and previous

Hello i use this package for one of my project for manage SEO tags, but i miss other not essencial tags like rel = next / previous for pagination seo, I locked in one fork of this package by Leadtech this functionality are implemented, will you add these modifications on master SeoBundle?¿

Thanks in advance, i dont know if there is the correct way of tell you that questions...

structure of SEO

Hi would it be possible to consider adding your structure to hand this variable :

http-equiv:
     'Content-Type':         text/html; charset=utf-8
     'X-Ua-Compatible':      IE=EmulateIE7
charset:
     UTF-8:    ''
head:
     "dir" : ltr
     'xmlns':              http://www.w3.org/1999/xhtml
     'xmlns:og':           http://opengraphprotocol.org/schema/

and maybe to get separatly "attributes" ?

<html  {{ leogout_seo_html_attributes()  }}>
       <head {{ leogout_seo_head_attributes() }} >
            {{ leogout_seo() }}
       </head>
</html>

Tank for your help

1.2.1 not compatible with Symfony 3.4

The root tree deprecation fix in 1.2.1 uses functions not available until Symfony 4, but composer.json still states it's compatible with 2 and 3. 1.2.0 works OK, but composer installs 1.2.1 by default as it expects it to be compatible.

deprecated since Symfony 4.2

hi have try your bundle and i get error deprecated :

   ›     $treeBuilder = new TreeBuilder();
    ›     $rootNode = $treeBuilder->root('leogout_seo');

are you plan to fix?

Thank

Symfony 5.3 Bug

hi i try to get install but i still having this issue

Service "leogout_seo.generator.generator" not found:

can you make update ?

Thank

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.