leohowell / redis-lru

LRU cache for Python. Use Redis as backend. Provides a dictionary-like object as well as a method decorator. pip install redis-lru

Hi there 👋

redis-lru's Issues

Non-hashable values in 0.1.1

Implementation of the excluded_values introduced in 0.1.1 does not allow to use non-hashable values. The problem is here, we cannot check if a non-hashable variable is in a set:

redis-lru/redis_lru/lru.py

Line 89 in 032f92f

if value in self.exclude_values:

Note that it makes 0.1.1 incompatible with 0.1.0

Where is the "LRU" part?

I read the source code. You are taking max_size as a parameter, but where are you using it?

AttributeError: 'float' object has no attribute 'items' (redis 3 compatibility)

Current implementation/example doesn't work with redis>=3:

Traceback (most recent call last):
  File "test.py", line 9, in <module>
    f(3) # This will print "Calling f(3)", will return 3
  File "/home/devin/.local/share/virtualenvs/redis-fun-0aEUqbK5/lib/python3.6/site-packages/redis_lru/lru.py", line 48, in inner
    return lru_cache[key]
  File "/home/devin/.local/share/virtualenvs/redis-fun-0aEUqbK5/lib/python3.6/site-packages/redis_lru/lru.py", line 64, in wrapper
    return method(self, key, *args, **kwargs)
  File "/home/devin/.local/share/virtualenvs/redis-fun-0aEUqbK5/lib/python3.6/site-packages/redis_lru/lru.py", line 224, in __getitem__
    p.zadd(self.access_key, time.time(), key)
  File "/home/devin/.local/share/virtualenvs/redis-fun-0aEUqbK5/lib/python3.6/site-packages/redis/client.py", line 2263, in zadd
    for pair in iteritems(mapping):
  File "/home/devin/.local/share/virtualenvs/redis-fun-0aEUqbK5/lib/python3.6/site-packages/redis/_compat.py", line 123, in iteritems
    return iter(x.items())
AttributeError: 'float' object has no attribute 'items'

Pinning redis at redis==2.10.6 fixes this.

Doesn't work with multiple clients

hash is not deterministic when used across multiple clients, so the cache will only hit with the client that created it: https://death.andgravity.com/stable-hashing#hash-not-stable-too-restrictive

Defeats the purpose of a distributed cache. Maybe use hashlib and pickle instead.

on reading data from redis-lru throwing error

Hi, looks like here reading data is in byte format and trying to converting using json loads. should be in string format

Traceback (most recent call last):
File "/usr/lib/python3.5/site-packages/redis_lru/lru.py", line 215, in getitem
value = json.loads(value)
File "/usr/lib/python3.5/json/init.py", line 312, in loads
s.class.name))
TypeError: the JSON object must be str, not 'bytes'

What your offer for pickle.dumps(value)

TypeError: cannot pickle '_thread.RLock' object