leon92101 / pwp-capstones Goto Github PK

Rubric Score

Criteria 1: Valid Python Code

• Score Level: 4 (Exceeds expectations)
• Comment(s): Great job, your code runs without any errors.

Criteria 2: Implementation of Project Requirements

• Score Level: 4 (Exceeds expectations)
• Comment(s): Very good, your code produces the suite of functions and classes required of it and calls them in an appropriate order.

Criteria 3: Software Architecture

• Score Level: 4 (Exceeds expectations)
• Comment(s): Nice job, your code is separated into distinct classes and functions, each of which are invoked for their own purposes.

Criteria 4: Uses Python Language Features

• Score Level: 4 (Exceeds expectations)
• Comment(s): Good, your code uses Python features appropriately.

Criteria 5: Produces Accurate Output

• Score Level: 3 (Meets expectations)
• Comment(s): In general you did a great job writing and testing all of your functions, with the exception of a small error in your frequency_comparison function (see issue #1).

Overall Score: 19/20

Excellent work!

There's a small error in your frequency_comparison function that results in identical frequency tables returning a similarity score of zero. To fix that, add an equal sign in your elif statement:

elif table1[i]<=table2[i]