leonardogentile / mobx-router5 Goto Github PK

Upgrade dependencies packages in order to make this plugin work with router5@5

When installing MobX 5+, NPM will fire warnings of react-mobx-router5's dependencies because it requires ^4.0.0. Can this be adjusted to (also) be compatible with ^5.0.0 ?

npm WARN [email protected] requires a peer of mobx@^4.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of mobx@^4.0.0 but none is installed. You must install peer dependencies yourself.

PS: Sorry for cross-posting but both libraries need to be updated.

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Invalid npm token.

The npm token configured in the NPM_TOKEN environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/.

If you are using Two-Factor Authentication, make configure the auth-only level is supported. semantic-release cannot publish with the default auth-and-writes level.

Please make sure to set the NPM_TOKEN environment variable in your CI with the exact value of the npm token.

Good luck with your project ✨

Your semantic-release bot 📦🚀

Need feedback from the guys who forked this or works directly with the source code.

Does my .idea IDE cofig gets in the way? Do you find it useful or you delete it asap?

Thanks

Im getting Could not find a declaration file for module 'mobx-router5' from my idea VSCode..

I can see an index.d.ts at the node_modules/mobx-router5/src folder.. and if I manually move it to be present at the root dir node_modules/mobx-router5, then the typings would start working.

Help?

Hi. I have followed all examples, provided in docs, but my router appears with null state. Here is my implementation:

import { createRouter } from 'router5';
import browserPlugin from 'router5/plugins/browser';
import loggerPlugin from 'router5/plugins/logger';
import { mobxPlugin, RouterStore } from 'mobx-router5';

const routerStore = new RouterStore();

const routes = [
  { name: 'signup', path: '/signup' },
  { name: 'user', path: '/user/:uid' },
];

export default function configureRouter(useLoggerPlugin = false) {
  const router = createRouter(routes, { defaultRoute: 'home' })
    .usePlugin(mobxPlugin(routerStore)) // Important: pass the store to the plugin!
    .usePlugin(browserPlugin({}));

  if (useLoggerPlugin) {
    router.usePlugin(loggerPlugin);
  }
  console.log('%c 1router', 'color: #ffcb14', router);
  return { router, routerStore };
}

as the results, my router store contains null in route props