leont / crypt-argon2 Goto Github PK

Hi,
do you have a plan to release this distribution on CPAN?

The documentation says:

my $encoded = argon2i_pass($password, $salt, 3, '32M', 1, 16):

Not the trailing colon instead of a semicolon

Hi Leon,

I am a little hesitant to file this as a bug report, but I bet that you would like to at least be aware: https://bugzilla.redhat.com/show_bug.cgi?id=2239146#c6

You may also be familiar enough with the CPU flags involved that you could add some valuable insight to that Fedora bug.

For some context, that bug spun out of this one, where there is a dependency on Crypt::Argon2: https://bugzilla.redhat.com/show_bug.cgi?id=2118421

Thanks for any help that you may be able to provide.

--
Lester

Not sure if there is much appetite for supporting older perls, but it's something I would appreciate.

The fix is pretty simple (see #6)

Hello, I am packaging Crypt::Argon2 on Debian and I noted that is missing a short description on POD documentation of script/argon2-calibrate, the patch below was applied on Debian side adding the description.

--- a/script/argon2-calibrate
+++ b/script/argon2-calibrate
@@ -71,7 +71,7 @@
 
 =head1 NAME
 
-argon2-calibrate
+argon2-calibrate - script to find the appropriate argon2 parameters
 
 =head1 VERSION

That would be good to apply it here on upstream side as well, but I guess the patch above must be adapted before apply here on upstream cause I noted that the POD on metacpan (from where Debian fetch the code) is modified by dist-zilla somehow.

I use a docker container to create debian packages for several perl modules using the "dh-make-perl" wrapper.

This worked fine the last years but we are now trying to migrate from buster to bookworm and see a very strange issue: The build host is my desktop running Ubuntu 22.04 with a 5.19 kernel. When I build the package inside the container it gets linked to "linux-vdso" which is obviously the one from the build host.

If I now install this package on a fresh bookworm system running with a "native" kernel 6.1 and run Crypt::Argon2::argon2id_pass I get a an Illegal instruction error and see this in the dmesg:

perl[15562] trap invalid opcode ip:7f5e46e3567c sp:7ffc75428480 error:0 in Argon2.so[7f5e46e34000+6000]

Building the package inside the container running on bookworm itself work.

Fedora no longer allows code licensed under Creative Commons CC0 1.0 [1]. I see that the C source code is dual-licensed under "Creative Commons CC0 1.0 License/Waiver or the Apache Public License 2.0, at your option". This is acceptable to Fedora. I would like to ask if you could please add the same dual-license statement (or another license acceptable to Fedora [2]) in each of the perl files, LICENSE, and README that are distributed with this project. This will allow Crypt::Argon2, which is needed by File::KDBX, which is needed by the next version of kpcli, to be added to Fedora.

Thanks.

[1] https://www.theregister.com/2022/07/25/fedora_sours_on_creative_commons/
[2] https://docs.fedoraproject.org/en-US/legal/allowed-licenses/