leptoquark1 / sw-blurhash Goto Github PK

It should be possible to list images which do not meet the 'exclusion' configuration settings and images with blurhash that no longer fit the 'exclusion' configuration.

1. A Cli command with structural output
2. Clean up with existing command and make it to be triggered from administration

I want to make this plugin compatible with FroshPlatformThumbnailProcessor.
While this plugin doesn't have thumbnails on any space, the system for thresholdThumbnail isn't suitable.

My idea would be:

If thresholdThumbnail occurs and the thumbnail doesn't exist on disk, the thumbnail should be generated on the fly to calculate the hash of it. Tested with calculated hash for 9MB jpeg which will never show any hash for client. Hash is calculated,

What do you think about it?

I have only put together a few ideas for mobile improvements here. Open for discussion...

Emulated integration

Processing

• Queue order should match the actual position of the Images in DOM
• Fixed or absolut image position should be respected - can their position in queue be corrected?

Misc

• Individual placeholders / loading state indicators while Blurhash is processing

Encoding

Hash Media-queries

Different hash sizes by device size (media-query), user-agent and similar classifications

The effort-benefit ratio should definitely be assessed in advance

File size limitation

Default exclusion for tiny and small images

Blurhash decoding using WebAssembly

Blurhash decoding using WebAssembly

First try with Rust was significant slower than the current implementation

To increase compatibility, it shall be possible to fetch the generated Blurhashes via the store api and admin api. The model MediaHashId fulfils all requirements about the data a consumer might need.

Exhaustive requirements for the resources are as follows

• fetch a single MediaHashId by mediaId
• fetch a lists of MediaHashId's by it corresponding mediaId's
• write MediaHashId for a single and multiple media entities (As seend as upsert backbone for outsourced processors)
• validation of media entities by its mediaIds that returns a subset of valid mediaIds or it corresponding thumbnail
• list missing images (Those which not meet the exclusion configuration)

In order to be able to use the plug-in as flexibly as possible, the current restrictions due to the global scope of the entire configuration settings regarding the encoding process are definitely a barrier.

There should be a structured inheritance dependence in which a media entity is the first instance and the global configuration is the last.

Especially through active marketing using the shopping experience, a targeted and optimised use of the individually adapted behaviour of teasers for key visuals and content or product presentation matched to its context and further content flow is possible.

Currently, the following configuration values would provide a suitable framework for this:

Performance and Encoding

• thumbnailThresholdHeight
• thumbnailThresholdWidth
• componentsX
• componentsY

These values can then be defined in the following order of decreasing valence:

Media Entity -> CMS Page -> Media Folder -> Global Scope

device (laptop):
Ryzen 9 5950hx
RTX 3060

hash WtH3Bgx]WXxZWYkCu6f*ofWBR*j?IonhogNHRjj[ivxYRkR-oJbI
1280 x 528
decode: 320 ms 😱

hash WPRysgayxuj[xuoft7ayRjj[WBay~qj[M{ayofayM{fQxuayt7of
600 x 600
decode 150 ms

Is it really normal?

To simplify the shop scaffold process or the creation of setup templates, the plugin should be able to be added via Composers require.

Just like validating and (re)generation of media entities (individually or by folder), it should be possible to exclude certain folders from generation. Media, however, can be excluded via tags.

The plug-in configuration can lead to confusion in the case of folders with the same name.

This feature is crucial for a fully well-rounded UX and maintainability of media that are considered for decoding from integration processes.

• Using the media browser
  • single images
  • folders
• Possibility to fully remove all generated Blurhashes when the plugin is uninstalled

Is there any reason you added the libraries static into this project, instead of using existing libs?

JS:
https://github.com/woltapp/blurhash/tree/master/TypeScript

PHP:
https://github.com/bepsvpt/blurhash
https://github.com/kornrunner/php-blurhash

Problem

For maximum compatibility of emulated integration, at least the explicit handling of background images should be possible.

Current Behavior

Currently no background images are processed by the emulated integration.

Expected behaviour

At least via Shopping Experience / CMS Rich Editors or by certain Twig functionalities, it should be possible to add background images that will be respected in integrations.

It's open for discussion on

• how to highlight those HTML Elements (by attributes or similar)
• as how to add this seamlessly to the existing CMS Rich Editor functionality in Administration
• how to adapt it to twig without leaving dependence to this plugin (Like enrich the twig core helpers)

Tied to preceding discussions a significant performance improvement in PHP Encoding process can be archived with the support of PHP 8, further plugins and so on

Using PHP Plugins / Packages

• krakjoe/parallel Requires ZTS and pthread
• justincjack/phpthreads Requires posix, sockets, pcntl

Using Subprocesses

• Symfony Components