lf201014 / sts_thmod_mrs Goto Github PK

The description of OrrerysSunPower in the game is "Whenever you comsume Charge-Up, deal some damage to all enemies". However, the actual effect is gaining block instead.

The description of the card OrrerysSun is correct, so the only wrong part is the description of that power.

This seems to be a long-standing problem. I'm sorry that I don't have the courage to submit a PR, because I know nothing about Frunch, Japanese or Korean (language).

游戏中“太阳仪”的能力描述是“每当你消耗蓄力层数时，对所有敌人造成伤害”，但实际上它的效果应当是获得格挡。

“太阳仪”这张卡牌的描述是正确的，所以关于这张牌唯一的错误就是关于能力的描述。

这个问题似乎已经有些年头了。很抱歉因为我不懂法语、日语和韩语，我个人不敢直接提 PR。

Game crashes upon choosing a blessing from Neow at the beginning. Works fine if you don't have the option.

No issue, just praise ... you've created my new favorite for Mod the Spire.

Hi,
I saw that ingame some card titles aren't displayed properly.
Specifically "Upsweep" is called "623B" ingame and then there are "66C" which is "D6C" in your Code and "6A" which is "_6A" in your Code.
I don't know if it's intentional for the last two since they're called the same in the source code but I thought I create an issue anyway.

When the card should activate (next turn) the game crash with this error.

Exception in thread "LWJGL Application" com.badlogic.gdx.utils.GdxRuntimeException: java.lang.NoSuchMethodError: com.megacrit.cardcrawl.dungeons.AbstractDungeon.returnTrulyRandomCard(Lcom/megacrit/cardcrawl/cards/AbstractCard$CardType;Lcom/megacrit/cardcrawl/random/Random;)Lcom/megacrit/cardcrawl/cards/AbstractCard;
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:133)
Caused by: java.lang.NoSuchMethodError: com.megacrit.cardcrawl.dungeons.AbstractDungeon.returnTrulyRandomCard(Lcom/megacrit/cardcrawl/cards/AbstractCard$CardType;Lcom/megacrit/cardcrawl/random/Random;)Lcom/megacrit/cardcrawl/cards/AbstractCard;
at ThMod_FnH.powers.Marisa.TalismanPower.atStartOfTurnPostDraw(TalismanPower.java:41)
at com.megacrit.cardcrawl.core.AbstractCreature.applyStartOfTurnPostDrawPowers(AbstractCreature.java:609)
at com.megacrit.cardcrawl.actions.GameActionManager.getNextAction(GameActionManager.java:393)
at com.megacrit.cardcrawl.actions.GameActionManager.update(GameActionManager.java:159)
at com.megacrit.cardcrawl.rooms.AbstractRoom.update(AbstractRoom.java:267)
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.update(AbstractDungeon.java:2624)
at com.megacrit.cardcrawl.core.CardCrawlGame.update(CardCrawlGame.java:892)
at com.megacrit.cardcrawl.core.CardCrawlGame.render(CardCrawlGame.java:465)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:225)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126)

It writes "Shuffle 5 random cards into your draw pile. Draw !M! cards. Each card has a !D! % chance to be Upgraded." "增加5張隨機牌中到抽牌堆並洗牌，抽 !M! 張牌。這些牌有 !D! %的機率被 升級",

What is "Each card" means? Those 5 random cards or the cards you draw later?

this mod causes random crash in "? room"
the "Mushrooms" in this json

/src/main/resources/localization/ThMod_MRS_events-zht.json

should be "Mushrooms_MRS" like other localization?

Since ZHS and ZHT share the same keywords but difference description.
Is there something can do to let it depend on the game language?

I think merging your beta branch to master branch will be better to know what was updated. I didn't know this until someone in Korean community said it so i didn't know that i needed to update Korean localization.

So, I found this Challenger Coin potion on a Marisa run, can't seem to use it, including from the map screen ... little help?

Screenshot ... https://i.postimg.cc/fLHzBk4W/Slay-the-Spire-challenger-coin.png

Hello, I'm from Korean StS community named "DC-inside Slay the Spire minor gallery".

We are happy to play as Marisa Kirisame in StS but, we want to share your masterpiece to other korean players too. we translated it and applied by changing file in localization folder.

I want to make a merge request with our works to add Korean localization. Can i do that?

Can you add a relic that activates when Marisa spends her charge-up?
Anything from gain gold, block, deal damage or debuff a random target, etc
Just figure spending charge-up could do something more flashy ...

Shoot the Moon currently removes a buff before dealing damage. Is this intended? If it is I'll change the card's wording to make it clearer.

The arts in this mod are very well-made, though I want to discuss some of the difference between the base game and the mod. Maybe it can help you creating those unfinish art.

In the base game, most of the time Attack card has red background, Skill card has blue background, some of the Skill card that mostly do attack thing also have red background, and power card... power card gets whatever color they want.
This way all cards have a consistent art style, and player can easily tell what those cards are.

It is a good practice to have its unique ID for most of the things, including cards.
If any mods show the same ID with your mod, their loc will be conflict and get overwrited.

e.g.
The card "Double Spark" have the ID "DoubleSpark", if another mod has the same ID, they will have conflict.

In some mods (like Slimebound), they name the ID like "Slimebound:LevelUp" for the card "Level Up".

I'm not sure if it's my side or server side, but my .jar downloads are very slow. Like 20KB/s slow. Maybe can upload .jar to kumpulbagi or some file sharing site for ease of access?

The game will freeze whenever I play the card 'Master Spark'
happen on both mac and window version

Please add Love-Colored Spark to Marisa's cards
Rare, 3 energy (2 energy upgraded), deals 10 damage & stuns an enemy

I mean, if it does for all the other spark cards i've played like simple spark, master spark, double spark... It technically should do that with Dark Spark aswell?

I've made a googly-eye-locations.json for Marisa, except relics, but i don't really see where to put the eyes on the relics, so i think it's okay
googly.zip

Oort Cloud's description is currently inaccurate to its effects. It states that it starts at 4+2 and upgrades to 6 +3, but the card's own java file states otherwise:

private static final int ARMOR_GAIN = 4;
private static final int UPG_ARMOR = 2;
private static final int AMP_ARMOR = 1;
private static final int UPG_AMP = 1;

As such, it goes from 4+1 to 6+2.

Upgrading it to the card description might be a bit much, though Marisa basically only has two solid enough blocks to survive between this and Asteroid Belt. Nerfing this while making it more accurate and making other block sources be more usable / actually having more block cards period, while weakening her glass cannon flavour, would also help her fit into higher Ascension.

反馈个bug
在打完激怒蘑菇的事件后拿了吃寄生回血的那个遗物，想了想不需要就回档了，退出去再继续游戏就闪退了。
不知这是魔理沙的问题还是basemod的问题，回档的时候当前回合拿到的遗物没清除。

06:29:25.457 INFO helpers.EventHelper> TRSR: 0.06
06:29:25.457 INFO helpers.EventHelper> ---------------------------
ERROR: Unspecified key: Mushrooms_MRS in EventHelper.
---------------------------
06:29:25.457 INFO basemod.BaseMod> Looking for custom events...
Exception: java.lang.NullPointerException
06:29:25.497 ERROR core.CardCrawlGame> Exception caught
java.lang.NullPointerException: null
at com.megacrit.cardcrawl.rooms.EventRoom.update(EventRoom.java:55) ~[desktop-1.0.jar:?]
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.update(AbstractDungeon.java:2552) ~[?:?]
at com.megacrit.cardcrawl.core.CardCrawlGame.update(CardCrawlGame.java:878) ~[?:?]
at com.megacrit.cardcrawl.core.CardCrawlGame.render(CardCrawlGame.java:429) [?:?]
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:225) [?:?]
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126) [desktop-1.0.jar:?]
Controllers: removed manager for application, 0 managers active
Game closed.

Immediately after using Mana convection my charge-up was reduced from 12 to 4 then I encountered a strange issue
Expected: The tooltip to tell me I had four charge-up and that my damage would be normal
Actual Result: tool tip said that I had 12 charge-up and double damage, although icon showed 4 charge-up, and cards reacted to charge-up as if I had four. (See screenshot)

Changing the name of the .jar file each time it updates messes up modTheSpire's auto-download thing.

I'm just going to leave the text here, as I'm not very good at Java.

          "你走進一條遍地是"
          + " #b~五彩斑斕蘑菇~ "
          + "的走廊，"
          + " NL 這些蘑菇和你之前見過的種類都不一樣。"
          + " NL 你想要將它們收集起來，但卻又有一種奇怪的衝動想要去吃一個"
          + " #b~蘑菇......~ ";

[收集] #r激怒蘑菇們。

Hi,
I managed to get the Enhanced Hakkero on the first floor thanks to Better Rewards mod, and then went into the wing statue event.
Taking damage to remove a card made the game crash.
This seems to be caused by onAttacked increasing the counter when taking damage outside of combat.

if (AbstractDungeon.getCurrRoom().phase == RoomPhase.COMBAT) should fix this.

I can not find the string myself. I'm playing in ZHT.

com.evacipated.cardcrawl.modthespire.patcher.PatchingException: javassist.CannotCompileException: [source error] Insert(com.megacrit.cardcrawl.screens.charSelect.CharacterOption,com.megacrit.cardcrawl.characters.AbstractPlayer,com.megacrit.cardcrawl.helpers.Prefs[]) not found in ThMod_FnH.patches.AscensionPatch$CharSelectFix
at com.evacipated.cardcrawl.modthespire.patcher.InsertPatchInfo.doPatch(InsertPatchInfo.java:209)
at com.evacipated.cardcrawl.modthespire.Patcher.finalizePatches(Patcher.java:144)
at com.evacipated.cardcrawl.modthespire.Loader.runMods(Loader.java:199)
at com.evacipated.cardcrawl.modthespire.ui.ModSelectWindow.lambda$null$1(ModSelectWindow.java:272)
at java.lang.Thread.run(Thread.java:748)
Caused by: javassist.CannotCompileException: [source error] Insert(com.megacrit.cardcrawl.screens.charSelect.CharacterOption,com.megacrit.cardcrawl.characters.AbstractPlayer,com.megacrit.cardcrawl.helpers.Prefs[]) not found in ThMod_FnH.patches.AscensionPatch$CharSelectFix
at javassist.CtBehavior.insertAt(CtBehavior.java:1213)
at javassist.CtBehavior.insertAt(CtBehavior.java:1140)
at com.evacipated.cardcrawl.modthespire.patcher.InsertPatchInfo.doPatch(InsertPatchInfo.java:183)
at com.evacipated.cardcrawl.modthespire.patcher.InsertPatchInfo.doPatch(InsertPatchInfo.java:207)
... 4 more
Caused by: compile error: Insert(com.megacrit.cardcrawl.screens.charSelect.CharacterOption,com.megacrit.cardcrawl.characters.AbstractPlayer,com.megacrit.cardcrawl.helpers.Prefs[]) not found in ThMod_FnH.patches.AscensionPatch$CharSelectFix
at javassist.compiler.TypeChecker.atMethodCallCore(TypeChecker.java:749)
at javassist.compiler.TypeChecker.atCallExpr(TypeChecker.java:695)
at javassist.compiler.JvstTypeChecker.atCallExpr(JvstTypeChecker.java:157)
at javassist.compiler.ast.CallExpr.accept(CallExpr.java:46)
at javassist.compiler.CodeGen.doTypeCheck(CodeGen.java:242)
at javassist.compiler.CodeGen.atStmnt(CodeGen.java:330)
at javassist.compiler.ast.Stmnt.accept(Stmnt.java:50)
at javassist.compiler.CodeGen.atStmnt(CodeGen.java:351)
at javassist.compiler.ast.Stmnt.accept(Stmnt.java:50)
at javassist.compiler.Javac.compileStmnt(Javac.java:567)
at javassist.CtBehavior.insertAt(CtBehavior.java:1192)
... 7 more

I have nothing against mod devs using art from the base game for their cards. However, it makes it very challenging if you use the same one over and over again. By chance, can you please make the cards all have different images on there? It would remove a lot of confusion. Thank you in advance.

I notice "Lumines Strike" seemed add the strike tag, so do you want to change the string to end with "打擊"? or keep as "聲光衝擊" for the lore?

The keyword, power file in src\main\resources\localization is empty, which make it cannot be translated.
Also these string in the pic.

fixed:

showing #p:

showing zhs because I can't find the string:

Given how Final Spark (and also Spark) works, Spark should be a keyword, just like Shiv in the base game.

Hello, thank you for creating this mod. recently, I've made a continuation project of this mod at https://github.com/scarf005/Marisa. However, since this repository lacks license, I'm not sure about the contribution of this project. Could you please specify the license (for example MIT)?

Latest patch broke this mod, was wondering if this should be moved to the Outdated section of the "List of Known Mods" in the Mod The Spire wiki.

It says
Deal !D! damage. NL If this kills a non-minion enemy in an Elite or Boss room, at the end of combat, obtain 1 random relic. NL Exhaust.
Will it work when it kills an Elite or a Boss in event? As it is not in an Elite or Boss room.

Hi, I've played a bit with your Mod and noticed there are some grammar problems and some things are worded poorly. Because of this I sometimes could not understand what certain cards do.

It seems like you're not a native English speaker. If you need help with this, hit me up.

Transient normally has the Shifting effect, causing it to lose strength equal to the damage taken. Shoot The Moon views this effect as a buff, removing it on use.

"OpenUniverse": {
"NAME": "开放宇宙",
"DESCRIPTION": "将五张随机卡牌加入抽牌堆并洗牌,然后抽 !M! 张牌。这些牌有 !D! %的几率被 升级 。",
"UPGRADE_DESCRIPTION": "将五张随机卡牌加入抽牌堆并洗牌,然后抽 !M! 张牌。这些牌有 !D! %的几率被 升级 。"
}

"OpenUniverse": {
"NAME": "Open Universe",
"DESCRIPTION": "Shuffle 5 random cards into your draw pile. Draw !M! cards. Each card has a !D! % chance to be Upgraded.",
"UPGRADE_DESCRIPTION": "Shuffle 5 random cards into your draw pile. Draw !M! cards."
}