lgfa29 / basiclti4moodle Goto Github PK

Make sure that the text on the submit button is internationalized.  Also make 
the name of the 
submit field to be "ext_submit" to comply with the spec.

What steps will reproduce the problem?
1. Set the LTI display mode to 'pop-up' 
2. Link an LTI resource in Moodle
3. Visit the LTI resource using Internet Explorer versions 6 to 8 

What is the expected output? What do you see instead?

The pop-up never appears, and an error message is accessible from the task bar 
- indicating a javascript error.

What version of the product are you using? On what operating system?

Not really applicable, but this only occurs on IE / XP using the current 
version of BasicLTI. Firefox on WinXP works fine.

Please provide any additional information below.

The following line in view.php is the culprit:

print "window.open('launch.php?id=".$cm->id."','window name');";

IE doesn't tolerate spaces in window names. The problem goes away if we change 
'window name' to 'window_name'

What steps will reproduce the problem?
1. Copied Moodle 2 /mod/basiclti folder to our Moodle 2 install
2. Logged into Moodle 2 site and went to install and got this error
3. Screenshot is attached,

What is the expected output? What do you see instead?

Should have installed sucessfully


What version of the product are you using? On what operating system?


Moodle 2.1.1+ (Build: 20110817)


Please provide any additional information below.

Need to allow the instructor to choose a frame height for the tool.

There are lots of places in the UI where help may or may not be needed - there 
are lots of places 
where help is missing.

What steps will reproduce the problem?
1. install moodle module
2. use instance in a course
3. go to "Course administration" => "Gradebook"
3. from the gradebook, go to "Scales"

What is the expected output? What do you see instead?

ERROR : php catchable fatal error

What version of the product are you using? On what operating system?

module : $module->version  = 2011052602;
moodle : $release  = '2.0.3+ (Build: 20110511)';

Please provide any additional information below.

Changing lib.php (line 285) :

FROM
if ($scaleid and $DB->record_exists('basiclti', 'grade', -$scaleid)) {
TO
if ($scaleid and $DB->record_exists('basiclti', array('grade' => $scaleid))) {

Seemed to solve the problem.

Just to make sure

When viewing activity report of Basic Lti getting error of moodle 

Module basiclti is missing the code needed to perform this function

Stack trace:

    * line 429 of /lib/setuplib.php: moodle_exception thrown
    * line 158 of /course/report/participation/index.php: call to print_error()

Develop Basic LTI Consumer for Moodle as activity Module 1.9

We will deal with specific tasks on our trac server at
http://potato.lsi.upc.edu

What steps will reproduce the problem?
1. try to use the basiclti module in a Webkit browser (Safari, Chrome, ...)

What is the expected output? What do you see instead?

Blank space in the place of the <object> tag, displaying "missing module".

What version of the product are you using? On what operating system?

Safari 5 and Chrome 13 on Mac OS X (10.6 and 10.7).

Please provide any additional information below.

To solve this, the MIME type of the <object> tag's content has to be specified 
: add ' type="text/html" ' in line 125 of mod/basiclti/view.php

Give the instructor the option to turn on or off debug launch.

Make the Admin option to send E-Mail to be a three-starte selection:  (1) 
Always Send, (2) Never 
Send, (3) Allow the Instructor to decide.  If the values are "Always or never", 
do not give the 
instructor an option to choose.  This shold be a separate column for the 
admin's choice and the 
instructor's choice, I would think.

What steps will reproduce the problem?
1. when navigating any instance of basiclti module in a course 
2.
3.

What is the expected output? What do you see instead?
Course Module ID was incorrect: 

What version of the product are you using? On what operating system?
IMS-Basic-LTI-for-Moodle-2010-May-30.zip

Please provide any additional information below.
The error disappear when replace the next line in launch.php
---------------------------------------------------------
if ($id) {
    //CRIS, bug encontrado y arreglado 2010-07-14
        //if (! $cm = get_record("course_modules", "id", $id)) {
    if (! $cm = get_record("course_modules", "instance", $id)) {
            error("Course Module ID was incorrect: ".$id." cm: ".$cm);
        }
---------------------------------------------------------

Add the ability to set custom fields and values in the admin interface - per 
the spec.

resource_link_title=My Weekly Wiki
A title for the resource. This is the clickable text that appears in the link. 
This parameter is 
recommended.

resource_link_description=…
A plain text description of the link’s destination, suitable for display 
alongside the link. Typically no 
more than several lines long. This parameter is optional.

Make the debug strings internationalized.

Somewhere, perhaps in the admin interface, we need to set the organization id, 
url, and 
description.

Add an option in the admin UI to select "popup" as well as the Instructor UI.

This is needed to pass the certification test.

Currently the consumer doesn't add the user_image to the launch request. If 
there is a way of addressing a Moodle user's profile image it would make sense 
to add it.

This goes to the latest IMS version of OAuth.php to handle parameters on the 
URL.

1. Create a BasicLTI activity with some data for some Tool Provider
2. Use this activity in multiple places within a course
3. All the BasicLTI links will send the same resource_link_id which is
incorrect; each link placement should have a distinct value for this parameter.

The problem appears to be the assignment of $instance->typeid to this param
in locallib.php's basiclti_build_request() function.  Instead,
$instance->id should perhaps be used.

The current code has debug hard-coded to "false" but it never auto-launched.  
The Javascript is 
placed in the background document - but it seems never to execute.

I would like Jordi to look over the current state of the code.  Since lots of 
it was written by non-
Moodlers (Nikolas and Chuck), I think that a look would be helpful.

I would pay particular attention to the locallib mod_form edit_form and view 
and launch code.

What steps will reproduce the problem?
1. Create a link to a test LTI Tool Provider (e.g. 
http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php)
2. Add a description to the link (e.g. "A description")
3. Execute a launch
4. Inspect the value of the resource_link_description parameter

What is the expected output?

"A description"

What do you see instead?

"<p>A description</p>"

What version of the product are you using?

basiclti4moodle-2012-03-15.zip with Moodle 2.2

On what operating system?

Windows 7

Please provide any additional information below.

The IMS spec requires this parameter to be plain text.  It can be fixed by 
changing line 120 of locallib.php to use the strip_tage function:

  "resource_link_description" => strip_tags($instance->intro),

BasicLTI4Moodle offers features over and above Moodle's core lti module but has 
steadily fallen behind regarding its use of the latest Moodle apis, 
current_language(), for instance. There are a number of old issues that haven't 
been attended to and the project seems to have stalled. As we are now intending 
to use it at my institution, Lancaster University (UK), I'm forking the project 
over onto my github account where we will make our changes. We'll keep all the 
licenses and attributions, but the commit history will likely be hosed.

What steps will reproduce the problem?
1. Create an external tool using IMS test site - 
http://www.imsglobal.org/developers/BLTI/tool.php
2. In a course create an activity
3. Access the activity

What is the expected output? What do you see instead?

Notice: Undefined index: query in /var/www/moodle19/mod/basiclti/OAuth.php on 
line 267

What version of the product are you using? On what operating system?
$module->version  = 2011041103;