GithubHelp home page GithubHelp logo

Comments (3)

lhl avatar lhl commented on May 26, 2024

Hmm, I'll look into that and probably rollback. ccing @aerickson (patch submitter) as fyi

from chrome-ssb-osx.

aerickson avatar aerickson commented on May 26, 2024

Sounds fine.

PDF viewing was not working without my patch previously (but it does seem to be working now -- not sure what changed... Chrome fixed this?). I haven't noticed focusing issues (I use TotalSpaces) and I didn't notice the app naming issue until now (but it's obviously going to happen with how the original script/my patch worked)... I was just happy with PDFs working.

from chrome-ssb-osx.

lhl avatar lhl commented on May 26, 2024

OK, cool tested that PDF viewing seems to work and I reverted the changes. Also added a note so we don't forget the symlink needs to be there for better app behavior. Thanks for the note @protocreate

from chrome-ssb-osx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.