liamzdenek / m2go Goto Github PK

Currently, no good documentation exists to explain what any of the source code is doing, and other developers are stuck reading my terrible code. Attach fairly descriptive comments to each struct, function, and anywhere that the code may require further explanation.

I profiled the hello_world example, and found that my long-running speculation was true- the existing route parsing logic (regexp based) is eating a lot of compute time- 32.9% to 49.4% of every request.

I suggest:

• Separating the route parsing logic from the Router, given that there are not too many performance implications. This should be a relationship similar to how SessionEngine relates to SessionHandler. (RouterEngine?)
• Implementing several route parsers, potentially including:
  • regexp matching
  • sscanf matching
  • string literal matching
  • matching similar to the one implemented in mongrel2
  • "catch-all" matching
    • possibly deprecating router.NotFound?

see go help remote

Currently, all session data is stored unencrypted, on the client. A handler should be introduced that allows the developer to encrypt the data before storing it on the client.