libbyberrie / snek-dancer Goto Github PK

Snektions are defined as 5% or 8% in width of the parent element, so unless sneks have many snektions the element is ending up much too wide.

We should maybe define the width in em instead, and set the font-size of the parent element to scale snakes up and down

Some snake words there could be puns from:

• Boa
• Taipan
• Serpent
• Anaconda
• Cobra
• Serpent
• Fang
• Mamba
• Viper

Mobile is a little bit fiddly. Amazingly, it works and looks pretty ok! But it could be improved with perhaps

• a mobile friendly layout (maybe some media queries to facilitate?)
• a bigger, more easily mashable button in mobile
• Code to stop mobile browsers double-tapping to zoom - as we'll be tap tap tappin dem snekkys

Prettier: Auto code formatting for JS based on accepted style guide (based on airbnb)

I've used Prettier on many JS codebases, and whilst initially I was a bit frowny face about auto-format-on-save, I've come around, these days. I find that:

• It saves time fiddling with lineups and the extra brackets in JS
• It removes the need to worry about what style is "best", by choosing for you
• It's actually pretty.... "pretty" - It comes up with a pretty nice end result

If we were to put it in

It would mean putting it in (a quite trivial PR in itself), and then running it on all JS files (also, we don't have many, not a huge job). I'd want to wait until we've all done with any code/PR's currently in the pipeline.

The main thing that would impact us as devs is that we'd likely want to install prettier on our local machines. There are vscode extension and sublime text plugins you can install to run it on save, and we could check-in some project-specific settings files so that this doesn't bother y'all on other projects. Or, you can run it on the command line before committing.

Open to discussion :)