🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency lint-staged was updated from 10.2.2 to 10.2.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

lint-staged is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency @typescript-eslint/eslint-plugin was updated from 3.0.2 to 3.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@typescript-eslint/eslint-plugin is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency @typescript-eslint/parser was updated from 2.31.0 to 2.32.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@typescript-eslint/parser is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

https://code.visualstudio.com/api/references/document-selector

We should explore this api and figure out possible usecases for uELS

likely, we should start with tests for it (add ember-template-lint) integration test

wrong: loded language server addons
correct: loaded language server addons

The devDependency @typescript-eslint/parser was updated from 2.19.0 to 2.19.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@typescript-eslint/parser is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency @typescript-eslint/eslint-plugin was updated from 2.19.0 to 2.19.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@typescript-eslint/eslint-plugin is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

usecase:

currently we have proxy command, in extension itself, it allow execute any VSCode command, and return execution results into any command

https://github.com/lifeart/vscode-ember/blob/master/src/extension.ts#L98

we need to create api to return result back to extension server and pass it down to addon

for example:

1.) addon: execute command ["create-file", "els:after-create-file"]
2.) server: execute command ["proxy-command", "create-file", "els:after-create-file" ]
3.) vscode: execute command "create-file"
4.) passing result back to extension
5.) extension passing result back to server
6.) server passing result back to "els:after-create-file", registered in addon

addon_command -> api_command -> extension_proxy -> (vscode command evaluation) -> extension_proxy -> api_command -> other_addon_command

example - https://github.com/microsoft/vscode-html-languageservice/blob/master/src/parser/htmlParser.ts

add ability to discover utils in path-matcher (for pods & classic apps), including utils tests

frontend\tests\integration\components\audio-player\component-test.js

it will be great to show parent route for current route template

https://github.com/lifeart/ember-language-server/blob/component-context-info-origin/src/utils/usages-api.ts

☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io

The devDependency lint-staged was updated from 10.1.5 to 10.1.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

lint-staged is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

WHY?

Idea is - allow users to install langerver extensions into project.

langerver extension -> npm package with special field in package.json and handler in js file.

in package.json we specify features we wanna handle, and handler expose api methods for it.

ELS addon example

package.json

"ember-language-server": {
    "entry": "./lib/langserver",
    "version": 1,
    "debug"? : true, // allow hot-reload addon logic without server restart
    "capabilities": {
      "definitionProvider": true,
      "referencesProvider": true,
      "completionProvider": true,
      "codeActionProvider": true
    }
}

lib/langserver.js

module.exports.onReference = async function(projectRoot, params) {
  return [
    {
      range: {
        end: {
          character: 0,
          line: 0
        },
        start: {
          character: 0,
          line: 0
        }
      },
      uri: "file://path/to/resolved/component.js"
    }
  ];
};

module.exports.onComplete = async function(projectRoot, { focusPath }) {
  if (focusPath.node.type === "ElementNode") {
    return [
      {
        label: "MyCustomComponent"
      },
      {
        label: "MyHardcodedComponent"
      }
    ];
  }
};

module.exports.onDefinition = async function(projectRoot, params) {
  return [
    {
      range: {
        end: {
          character: 0,
          line: 0
        },
        start: {
          character: 0,
          line: 0
        }
      },
      uri: "file://path/to/resolved/component.js"
    }
  ];
};

refs: vastec/ember-unused-components#56

Addon API interface

import { Definition, FileChangeType, Diagnostic, TextDocument, Location, TextDocumentIdentifier, Position, CompletionItem, CodeActionParams } from 'vscode-languageserver';
import Server from '../server';
import ASTPath from './../glimmer-utils';

type Executor = (server: Server, command: string, args: any[]) => any;
type Linter = (document: TextDocument) => Diagnostic[];
type Watcher = (uri: string, change: FileChangeType) => any;

type MatchResultType =
  | 'helper'
  | 'service'
  | 'route'
  | 'controller'
  | 'modifier'
  | 'template'
  | 'component'
  | 'model'
  | 'transform'
  | 'adapter'
  | 'serializer';

interface MatchResult {
  type: MatchResultType;
  name: string;
}

interface Project {
  root: string; // project entry path
  addCommandExecutor(key: string, fn: Executor): void;
  addLinter(fn: Linter): void;
  addWatcher(fn: Watcher): void;
  matchPathToType(filePath: string): null | MatchResult;
}

interface Registry {
  component: {
    [componentName: string]: string[] // files, related to component
  },
  service: {
    [serviceName: string]: string[] // files, related to service
  },
  routePath: {
    [routePath: string]: string[] // files, related to route (templates, controllers, routes)
  }
}

interface Command {
   command: string // els.executeInEmberCLI
   arguments: any[] // first argument - file path / project root, if command scoped to project
}
interface Server {
  getRegistry(projectRoot: string): Registry;
  onExecute(command: Command): any;
  getUsages(normalizedName: string): string[]; // return list of files, related to token
}

interface BaseAPIParams {
  server: Server;
  textDocument: TextDocumentIdentifier;
  position: Position;
}
interface ExtendedAPIParams {
  focusPath: ASTPath;
  type: 'script' | 'template';
}
interface ReferenceFunctionParams extends BaseAPIParams {
  results: Location[];
}
interface CompletionFunctionParams extends ExtendedAPIParams {
  results: CompletionItem[];
}
interface DefinitionFunctionParams extends ExtendedAPIParams {
  results: Location[];
}

interface CodeActionFunctionParams extends CodeActionParams {
  results: (Command | CodeAction)[];
  server: Server;
  document: TextDocument
}

type ReferenceResolveFunction = (root: string, params: ReferenceFunctionParams) => Promise<Location[]>;
type CompletionResolveFunction = (root: string, params: CompletionFunctionParams) => Promise<CompletionItem[]>;
type DefinitionResolveFunction = (root: string, params: DefinitionFunctionParams) => Promise<Location[]>;
type CodeActionResolveFunction = (root: string, params: CodeActionParams) => Promise<(Command | CodeAction)[] | undefined | null>;
type InitCallback = (server: Server, project: Project) => void;


export interface AddonAPI {
  onReference: undefined | ReferenceResolveFunction;
  onComplete: undefined | CompletionResolveFunction;
  onDefinition: undefined | DefinitionResolveFunction;
  onCodeAction: undefined | CodeActionResolveFunction;
  onInit: undefined | InitCallback;
}

Addon api:

addon-api.ts

Addons:

• els-a11y-addon
• els-component-extraction-addon
• els-addon-typed-templates
• els-addon-docs
• els-intl-addon

Ember addons with langserver API:

• ember-cli-inline-template-only-components
• ember-template-imports
• ember-fast-cli

Wiki: https://github.com/lifeart/ember-language-server/wiki

• fix parsing for case like <:foo></:foo>
• search closest parent, if parent is an resolvable component, get blocks from it and return as autocomplete

We have configured template-lint to skip the tests directory (see https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/ignore.md). However, the VSCode extension still marks the hbs templates in my tests as errors. It would be nice if the extension would use the ignore setting from my .template-lintrc file.

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency @typescript-eslint/parser was updated from 2.32.0 to 2.33.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@typescript-eslint/parser is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

https://github.com/lifeart/ember-language-server/blob/component-context-info-origin/src/utils/diagnostic.ts#L17
glimmerjs/glimmer-vm#1203

Description

This error only reproduces after performing the following steps:

1. Create an ember octane application. (using [email protected])
2. remove ember-cli-template-lint and install ember-template-lint.
3. change extends: 'octane' to extends: ['octane', 'stylistic'] in .template-lintrc.js
4. remove ember-cli-eslint and install eslint
5. now open a .js or .hbs file, change anything and save, should see the following:

and as the screenshot shows, execute linting in the command line won't detect any real errors, it's only happening in the editor.

Reproduction Repository

https://github.com/nightire/vscode-linting-error

Environments

• ember-cli version: v3.6.0
• ember.js version: ~3.16.0
• node version: v12.14.1
• ember-language-server version: v0.3.8

Steps to reproduce:

1.) open any hbs file, with linting issue
2.) disable rule in template-lint-config
3.) open this file one more time

Expected behavour:

• no error shown (from step 1)

Existing bahavour:

• error is shown, changes applyed only project reload

☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io

The devDependency @typescript-eslint/eslint-plugin was updated from 2.30.0 to 2.31.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@typescript-eslint/eslint-plugin is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency prettier was updated from 1.18.2 to 1.19.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

prettier is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency lint-staged was updated from 10.2.6 to 10.2.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

lint-staged is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency @typescript-eslint/parser was updated from 3.0.2 to 3.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@typescript-eslint/parser is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Hello, great extension, thanks, I found this little bug.

I have this component

{{tables/i18n-models-table}}

The angle brackets equivalent is

<Tables::I18nModelsTable />

And the extension autocompletes with the n after the 18, upper case, like this:

<Tables::I18NModelsTable />

clicking on yield or yield to="slot-name" we have to show usages block usages/slots usages for this component

#12

inputs:

we shold have ability to add minimalistic autocomplete format for (at least) template scope (for addon autors)

for example:

const autocompleteInfo = {
    modifiers: [
        {
            name: 'foo-bar', 
            description: '', 
            file: fsPath, 
            namedArguments: [
                { 
                    name: 'foo', 
                    description: 'boo', 
                    defaultValue: 'foo' 
                }
            ]
        },
    ],
    helpers: [
        {
            name: 'foo-bar', 
            description: '', 
            file: fsPath, 
            namedArguments: [
                { 
                    name: 'foo', 
                    description: 'boo', 
                    defaultValue: 'foo' 
                }
            ]
        },
    ],
    components: [
        {
            name: 'foo-bar', 
            description: '', 
            file: fsPath, 
            namedArguments: [
                { 
                    name: 'foo', 
                    description: 'boo', 
                    defaultValue: 'foo' 
                }
            ]
        }
    ]
}

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency lint-staged was updated from 10.2.4 to 10.2.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

lint-staged is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I'm getting the error "Property 'args' does not exist on type 'Template'" when using @argumentName in my templates. I reinstalled the extension and still get it.

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency @typescript-eslint/eslint-plugin was updated from 2.31.0 to 2.32.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@typescript-eslint/eslint-plugin is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io

The devDependency ts-jest was updated from 25.2.1 to 25.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ts-jest is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

{{!-- template-lint-disable no-inline-styles style-concatenation --}}

test example: https://github.com/lifeart/ember-language-server/blob/component-context-info-origin/test/integration-test.ts#L1230
logic in: https://github.com/lifeart/ember-language-server/blob/component-context-info-origin/src/builtin-addons/core/script-definition-provider.ts#L191

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency @typescript-eslint/eslint-plugin was updated from 2.32.0 to 2.33.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@typescript-eslint/eslint-plugin is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The dependency @glimmer/syntax was updated from 0.47.5 to 0.47.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@glimmer/syntax is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency @types/lodash was updated from 4.14.153 to 4.14.154.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/lodash is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

04/02/2019

• ability to go to component style if css-modules used (lense)
• allow langserver handle diynamically created projects inside working dir

02/12/2019

• allow ember projects have internal addon-api #25

03/12/2019

• workspaces support b7db162

05/12/2019

• template: block params autocomplete #30
• template: scoped params autocomplete #29

08/12/2019

• linter batching (allow to execute multiple linters per file) #33

10/12/2019

• server.addToRegistry method, to allow addon autors implement custom layout support

19/12/2019

• allow addons handle project-scoped command execution
• els.runInEmberCLI command, ability to execute custom command if ember-fast-cli installed.
• Addon API onInit function support.

21/12/2019

• improved go-to component template definition logic
• registry initialied during project initialization
• added logging for els-addon names, added to project
• workspace folders change event support
• Addon API addWatcher funnction (ability to watch file changes)
• private Projct.files (list of all project files)

23/12/2019

• updated angle bracket naming normalization
• implemented Matcher api (improve project files discovery)

24/12/2019

• test files lookup (lense)
• els.getRelatedFiles command, ability to load related files (by path)

26/12/2019

• addon component files lookup (for addon autors) (lense)

04/02/2020

• runtime project lookup (if ember-cli-build.js file appear)
• lense: component styles (added support for css modules)

04/02/2020

• ability to have local els addons (non project-scoped)

21/02/2020

• show rule name in template-linter messages

09/03/2020

• ability to reload project from button (VSCode)

02/05/2020

• lense: pod-styled component tests discovery

03/05/2020

• Ember File Usages feature (for components)
• els.getKindUsages - allow ELS Addons resolve files by normalized token name

10/05/2020

• Addon API: code action api

20/05/2020

• Adon API: path matcher kind https://github.com/lifeart/ember-language-server/pull/106/files

23/05/2020

• template-lint rule-fix feature
• fixed lense for addon/app files
• fixed template-lint initialization without global node path
• els.proxyCommand - allow ELS Addons execute any vscode command

Hi --
First of all -- I love this extension!

Recently, I updated from 1.1.0 and Go to Definition on a component in a handlebars file started jumping to the component's test file instead of it's component template.

I've given this a shot in versions 1.1.1, 1.2.1, 1.2.2 and 1.3.2 and the issue is the same in all of them.

Things are working on 1.1.0 for me.

How can I help assist debugging this?
I'm guessing something funky is going on in here?
https://github.com/lifeart/ember-language-server/blob/component-context-info-origin/src/definition-providers/template.ts

The problem seems to be that the something fails once there is a linebreak in between opening and closing HTML tag. The problem manifests itself as "no quick fixes available" in vscode.

• Affected plugin
• Discussion on Discord
• PR with a failing test

 FAIL  test/bultin-addons/core/template-linter-test.ts
  ● ProjectTemplateLinter › it return valid result on template with linebreaks

    TypeError: Cannot read property 'type' of undefined

      19 |
      20 |   while (cursor) {
    > 21 |     if (validNodes.includes(cursor.node.type)) {
         |                                         ^
      22 |       return {
      23 |         selection: focusPath.sourceForNode(),
      24 |         location: focusPath.node.loc,

Using nvm to manage my node, I ran into an issue where my template linting was not working at all. With @lifeart 's guidance, we narrowed it down to this block:

if (!nodePath) {
  return;
}

inside the getLinter getting hit, which I guess bails on everything else. Commenting this out return the linting in my editor. 👏