liferaycloud / marble Goto Github PK

https://github.com/wedeploy/marble/blob/master/src/_box.scss#L140-L141
https://github.com/wedeploy/marble/blob/master/src/_content-body.scss#L160-L162
https://github.com/wedeploy/marble/blob/master/src/_content-header.scss#L69-L74
https://github.com/wedeploy/marble/blob/master/src/templates/docs/_guide.scss#L35-L36
https://github.com/wedeploy/marble/blob/master/src/templates/root/_elements.scss#L30-L31

inline-block will be ignored if float is given a value, as it naturally produces a block effect. Is there a reason for this (say, unhiding a display:none element, or would you like a PR to remove the unused display style?

See: https://stackoverflow.com/questions/27511533/difference-between-display-block-float-left-vs-display-inline-block-flo#answer-27511744

https://stackoverflow.com/questions/46472801/from-gulp-iconfontcss-to-webpack
https://www.npmjs.com/package/webfonts-loader
https://www.npmjs.com/package/icons-loader

Running Electric 1.3.2 and Marble 2.4.4

When on /docs the header and body elements are working, but when you select a specific guide, the ui breaks near the header.

On Docs home:

On a Docs child:

The font size of the list on the blog is 1.05895rem and I believe that 1rem would match the rest of the text in <p>.

Npm says: Sadly, this package has no readme. Go write one!

I'm working on moving away from JSDOM usage, but some components are still depending on that.

ex:

> info Ready on http://0.0.0.0:3005
> ERR!   ReferenceError: document is not defined
> ERR!
> ERR!   - Dropdown.js:64 Dropdown.attached
> ERR!     [console]/[marble-dropdown]/lib/Dropdown.js:64:52
> ERR!
> ERR!   - Component.js:243 Dropdown.attach
> ERR!     [console]/[metal-component]/lib/Component.js:243:10
> ERR!
> ERR!   - Component.js:633 Dropdown.renderComponent
> ERR!     [console]/[metal-component]/lib/Component.js:633:9
> ERR!
> ERR!   - render.js:561 renderSubComponent_
> ERR!     [console]/[metal-incremental-dom]/lib/render/render.js:561:8
> ERR!
> ERR!   - render.js:473 renderFromTag_
> ERR!     [console]/[metal-incremental-dom]/lib/render/render.js:473:14
> ERR!
> ERR!   - render.js:220 Topbar.handleChildrenCaptured_
> ERR!     [console]/[metal-incremental-dom]/lib/render/render.js:220:9
> ERR!
> ERR!   - children.js:161 handleInterceptedCloseCall_
> ERR!     [console]/[metal-incremental-dom]/lib/children/children.js:161:24
> ERR!
> ERR!   - incremental-dom-aop.js:110 Object.handleCall
> ERR!     [console]/[metal-incremental-dom]/lib/incremental-dom-aop.js:110:12
> ERR!
> ERR!   - incremental-dom-aop.js:91 fnVoid
> ERR!     [console]/[metal-incremental-dom]/lib/incremental-dom-aop.js:91:37
> ERR!
> ERR!   - incremental-dom-aop.js:110 Object.handleCall
> ERR!     [console]/[metal-incremental-dom]/lib/incremental-dom-aop.js:110:12
> ERR!
> ERR! {
> ERR!   "status": 500,
> ERR!   "message": "document is not defined"
> ERR! }

I suggested reducing the amount of lifecycle to mimic what React does for SSR: metal/metal.js#318

Not sure if it would be accepted, but we also can work on having workarounds for when the component is rendered on SSR

@jonnilundy commented on Thu Aug 03 2017

Currently, a 15 Macbook screen will display 11 items on the reading progress bar when the whole bar is displayed. Once there is more than that, it breaks and doesn't show the lower items to the user. We need to make it extendable so more content sections can be added.

Here is what it looks like with 11 items:

With hover, as the user is scrolling through the menu, the item that tracks with their thumb placement turns green.

https://cl.ly/1j1i020E0L33

https://github.com/wedeploy/marble/search?utf8=%E2%9C%93&q=it.skip&type=

Had this issue reported in liferay/electric#59, but it looks like something that needs to be addressed in marble.

• Create CSS component
• Create JS component

• marble-alert
• marble-autocomplete
• marble-datatable
• marble-dropdown
• marble-input
• marble-input-matrix
• marble-progress-bar
• marble-reading-progress
• marble-select
• marble-slider
• marble-toast
• marble-tooltip

I tried adding this block of code to the tutorials but it was not adding the aside styling like we see in the docs.

I also tried this code in a docs md and it worked.

<aside>

###### Something to notice

If you go to `{$page.directory}/hosting/main.js` you will notice some of the Email API logic inside. One call you will use a lot is `post()`, which is the command that sends the email.

</aside>

@jonnilundy commented on Wed Feb 28 2018

@zenorocha commented on Thu Mar 08 2018

This looks broken on electricjs.com as well.

Currently our packages are pulling from the github master branch.

If I want to use parts of marble css, I think I’ll need to manually import the core files like this:

https://github.com/wedeploy/marble/blob/master/packages/marble/src/marble.scss#L1-L22

That might be dangerous to manage all those rewritten imports on the implementation side. Perhaps we could make a marble-core.css file for these situations?

Hello,

Description

A bug at the .input-group-btn, the same with the z-index: 3, overlapping the topbar at section Buttons Addons. At docs.

Preview

Check

Today we have independent releases with different versions for each package.

For example, marble-topbar could be 2.3.1 and marble-dropdown could be 3.6.2.

https://github.com/wedeploy/marble/blob/master/lerna.json

This is good because semver will serve as a communication interface to tell people who depend on these packages if there's a breaking change or not.

Clay on other hand does everything with the same version.

For example, if clay-topbar is 2.1.1 then clay-dropdown would be 2.1.1 too.

https://github.com/liferay/clay/blob/master/lerna.json

I'm not sure what is the best approach here, just interested in starting a conversation about this topic.

@NolanChan commented on Wed Feb 07 2018

It seems like the Reading Progress Tracker is pretty inaccurate on some pages. In the picture below, I'm right at the second topic, but it says I've only finished up to half of the first.

This is probably more an electric problem than a wedeploy.com problem, so I don't mind moving this issue over there if need be

Edge version: 41.16299.15.0

Looking at http://marblecss.wedeploy.io/docs/components/icon.html which might not be updated, icon-16-bug is missing.

@ygorcosta commented on Fri Oct 27 2017

Related to liferay/electric#36

• Create CSS component
• Create JS component

Babel already ships with this so there's no need for us to include it.

Boilerplate references in this repo

• checklist

@zenorocha commented on Tue Nov 01 2016

When you have a huge list of repositories it's super painful to find the one you're looking for using this dropdown.

My suggestion is to include a search box on it, that way you can easily filter what you want.

https://harvesthq.github.io/chosen/

@vitorfernandes commented on Tue Nov 01 2016

https://projects.invisionapp.com/d/#/console/9058505/199007612/preview

Done!

• Create CSS component
• Create JS component

Someone using Electric sent me this screenshot.

• topbar
• spinner
• radio-group
• checkbox-group