linebender / vello_svg Goto Github PK

Is there a way to set a color/brush override?

If not, would a PR for that be accepted?

I do this a lot in bevy_vello - It feels very verbose!

                // SVG -> Scene
                let svg_tree = bevy_vello::vello_svg::usvg::Tree::from_str(
                    &svg_contents,
                    &Default::default(),
                    &Default::default(),
                )
                .unwrap();
                let mut scene = bevy_vello::vello::Scene::new();
                bevy_vello::vello_svg::render_tree(&mut scene, &svg_tree);

This is pretty much the requirement for every SVG load, which feels pretty dumb.

We can surely do better, can't we? e.g. vello_svg::render_str(&str) -> Scene.

Proposal:

• Introduce a usvg cargo feature.
  • Move vello_svg::render_tree behind this feature.
  • Move vello_svg::render_tree_with behind this feature.
  • Re-export vello_svg::usvg behind this feature.
• Add a vello_svg::render_str(&str) -> Scene method (uses default usvg opts)
• Add a vello_svg::render_str_to(&str, &mut Scene) method (uses default usvg opts)

Thoughts, @DJMcNab ?

Right now, a lot of the useful functions in vello_svg is locked up inside a private util mod:

pub fn to_affine(ts: &usvg::Transform) -> Affine
pub fn to_stroke(stroke: &usvg::Stroke) -> Stroke
pub fn to_bez_path(path: &usvg::Path) -> BezPath
pub fn into_image(image: image::ImageBuffer<image::Rgba<u8>, Vec<u8>>) -> Image
pub fn to_brush(paint: &usvg::Paint, opacity: usvg::Opacity) -> Option<(Brush, Affine)>
pub fn decode_raw_raster_image(
    img: &usvg::ImageKind,
) -> Result<image::RgbaImage, image::ImageError>

As a user from the outside, it would be nice if I can access these functions and use it to transform an Svg into custom data struct that uses Vello types other than just Scene (maybe a collection of BezPaths).

Similarly as:

https://github.com/RazrFalcon/resvg/blob/ac7e7d0c40eb22dae19139f36ce28ad16e123db4/crates/resvg/src/render.rs#L45