linemanjs / lineman-bower Goto Github PK

npm WARN deprecated [email protected]: wrench.js is deprecated! You should check out fs-extra (https://github.com/jprichardson/node-fs-extra) for any operations you were using wrench for. Thanks for all the usage over the years.

I'm not sure how it affects the functionality.

To keep the Lineman configuration from getting out of sync with .bowerrc, read from .bowerrc to get the bower installation directory, and use this value for the Clean task.

By default, lineman-bower will not copy new dependencies into the /vendor/bower. I'm not a Bower expert, but I thought that lineman-bower would let me specify JS dependencies and have them automatically included in my Lineman app...but it doesn't by default. Why? Am I overlooking some other use case for Bower?

https://github.com/linemanjs/lineman-bower/blob/master/config/plugins/bower.coffee#L18

bower:
   install:
     options:
       copy: false

To install dependencies with Bower, I had to override this config in /config/application.js.

At the very least, the documentation should be updated to mention this behavior and how to override it (and yes, I am volunteering to update the docs if this is an appropriate solution).

I basically copied the example in the README and lineman build failed:

Running "browserify:common" (browserify) task
Verifying property browserify.common exists in config...OK
Files: app/js/entrypoint.coffee -> generated/js/browserify.js
>> Error: module "jquery" not found from "my_lineman_app/app/js/entrypoint.coffee"
Warning: Error running grunt-browserify. Use --force to continue.

app/js/entrypoint.coffee

window.$ = require('jquery')(window);
require("./hello")

config/files.js

module.exports = function(lineman) {
  return {
    //Override file patterns here
    js: {
      vendor: [
        "vendor/bower/jquery/dist/jquery.js",
        "vendor/js/**/*.js"
      ]
    }
  };
};

Simplify install directions by initiating a default .bowerrc before running the bower task if one is missing from the project path.

As of version 0.0.4 running lineman run issues the following warning:

Running "bower:install" (bower) task
Warning: Cannot find module 'grunt' Used --force, continuing.

I am guessing this is related to the changes in commit 3a65e3e on line 23.

With the introduction of the vendor/bower directory, we need to add "vendor/bower" to the watch ignore option.

Ref: testem/testem#301

Details:
I have tested this where I have lot of directories in the vendor/bower directory and if I run "lineman spec", then it fails with error watch: EMFILE. (see Ref)

It seems that testem + fireworm have addressed this issue and bumped the version up.

Solution:

1. Add skipDirEntryPatterns:['node-modules', 'vendor/bower', '.*'] to fireworm config via this module
2. Update testem+fireworm in lineman itself.
3. Update the README to suggest the bower directory be created under the node_modules

Since this module creates 'vendor/bower', it would be nice that it would also handle the testem+firewom config directly.