linster / plastregsystem Goto Github PK

Currently AuthenticationService handles the RoleHierarchy delegation. This needs to be fixed to use the roles definied in ApplicationContext.xml (instead of just hardcoding).

See PlastRegSystemUI.java

If you log out of the system, then type in the URL for a protected page again, the page will display. If you create a new tab (or a new browser session), page protection works properly. A user who was never authenticated still cannot view a protected page, however. For some reason, if I clear the THREAD_LOCAL Authentication object in the Logout Handler, the ViewChangeSecurityChecker doesn't work.

Reproduction:

Open Incognito Mode. Login, select the Online Information View. Copy the URL to the view.
Log out. Paste the URL into the address bar. Notice how the view is still displayed. (this tab once had an authenticated user).

Open another incognito tab. Paste the URL in. You will be redirected to the Login page.

Cheeky fix:
Instruct the user Ualberta-style to close absolutely everything after logging out. Maybe throw their computer out of a window.

Severity:
Medium. It would be an issue on public computers where people start messing around with URLs in tabs/sessions that once had an authenticated user.
However, no user who has never been authenticated could just get in, so it's not a huge issue.