launching with Xmx1024M may override user preferences in data system.properties about docker-unifi-controller

[johnthepro]

In my testing so far, I've noticed that even if the unifi.xms and .xmx values are set in system.properties, they seem to be ignored by the application. ps aux inside the container doesn't show the java process having been launched with any extra parameters, although i'm not sure that it is supposed to if configured via system.properties.

As you mentioned, an environment variable in the 'run' command could allow the user to pass through the desired values at image launch. I'm going to do some more testing with the environment variables idea and see if they pass-through and are respected as such.

[bagobones]

You may be right, I do know that by removing the forced Xmx1024M I was able to run for a longer period of time but ultimately it did lockup again because of excessive memory use.

I was just linking to that solution as it is supposed to be the official fix.. Having the variables exposed however would make the container very flexible.. I have tried constraining the memory via docker but JAVA just consumes the memory anyway. Apparently this is a known issue with running JAVA 8 in a docker. Here is a more complete breakdown of the known problem with a few fixes when using JAVA in docker https://developers.redhat.com/blog/2017/03/14/java-inside-docker/

[teknofile]

I agree, this could be an issue for RPi users. I did some real quick testing and I think it would be easy enough to set an ENV in the Dockerfile to the amount of memory to allocate and update root/etc/services.d/unifi/run to start ace.jar with that. If you want I can submit a PR, @j0nnymoe