lionkor / inspire Goto Github PK

If someone were to add ideas containing tokens used by bash or a similar shell, such as $HOME, they should put the entire idea in quotes. In this case, however, we should ignore the quotes when storing the idea.

Currently the workaround is to edit $HOME/.inspire/data, but this should at least be somewhat easier to find. Just printing the path with a command like inspire file would make inspire file | vim possible and solve the issue (somewhat).

An option to "reply" to the output of inspire give to say "please remove this one from the list" would be best.

Currently, the $HOME/.inspire/data file could be replaced by anything, like a symlink to a huge file. This is kind of dangerous, and I don't see why we would load arbitrary files. This could be used to OOM the system, for whatever reason one might do this.

One way to fix this is to choose some random number like 500MB and assume that this is will never OOM the system, then stat the file before we read it to make sure that it's not larger than that (which would be a ridiculous amount of ideas).

Another way to fix this is to add a header to the file head. You could still OOM by appending a large amount of data, but the original problem would be fixed.

Now this problem seems ridiculous and this is an edge case that will never happen, but I feel like this is easy to implement, and its good to make this program as solid as possible.