Feature: Allow options for configuring pkp wallet singing implementation about js-sdk

[Ansonhkg]

Sure. Let me know if the following works for you:

yarn add @lit-protocol/[email protected]

const pkpWallet = new PKPWallet({
  pkpPubKey: PKP_PUBKEY,
  controllerAuthSig: CONTROLLER_AUTHSIG,
  provider: "https://rpc-mumbai.maticvigil.com",
  debug: true,
  // if both code and ipfsId are not provided then it will use the default lit action code
  // litActionIPFS: "QmRwN9GKHvCn4Vk7biqtr6adjXMs7PzzYPCzNCRjPFiDjm",
  litActionCode: `
  (async () => {
    const sigShare = await LitActions.signEcdsa({ toSign, publicKey, sigName });
    console.log("extraParams:", extraParams);
  })();
  `,
  litActionJsParams: {
    // this will override the default toSign param
    // toSign: [1, 2, 3, 4, 5],

    // extraParams
    extraParams: [1, 23],
  },
});

[Ansonhkg]

Hey @joshLong145, you can extend our PKPWallet class to add more custom configurations like this repo:
https://github.com/LIT-Protocol/lit-pkp-sdk/blob/main/src/index.js

Would it help?

[joshLong145]

Hey @joshLong145, you can extend our PKPWallet class to add more custom configurations like this repo: https://github.com/LIT-Protocol/lit-pkp-sdk/blob/main/src/index.js

Would it help?

this is essentially what we have done to create custom implementations the pkp's signing mechanism. but it would be nice if configuration options where added to the props

[Ansonhkg]

great! i'll add that to my to-do

[Ansonhkg]

Hey @joshLong145 we've added pkp-ethers to this repo now you can install it via:

yarn add @lit-protocol/pkp-ethers

You can now edit your lit action code via the constructor eg:

  const pkpWallet = new PKPWallet({
    pkpPubKey: PKP_PUBKEY,
    controllerAuthSig: CONTROLLER_AUTHSIG,
    provider: "https://rpc-mumbai.maticvigil.com",
    debug: true,
    litActionCode: `
    (async () => {
      console.log("Testing");
    })();
    `,
  });

Let me know if this work for you?

[joshLong145]

Hey @joshLong145 we've added pkp-ethers to this repo now you can install it via:

yarn add @lit-protocol/pkp-ethers

You can now edit your lit action code via the constructor eg:

  const pkpWallet = new PKPWallet({
    pkpPubKey: PKP_PUBKEY,
    controllerAuthSig: CONTROLLER_AUTHSIG,
    provider: "https://rpc-mumbai.maticvigil.com",
    debug: true,
    litActionCode: `
    (async () => {
      console.log("Testing");
    })();
    `,
  });

Let me know if this work for you?

Would it also be possible to add ipfsId and jsParams to the PKPWallet props? this would allow for usage of registered cids and to pass arbitrary parameters to action implementations. This would then mean you can define either litActionCode or ipfsId making both optional props. If none are provided then perhaps defaulting to the implementation you have outlined above.