Comments (5)
@edgarrmondragon Yes. Thanks. And released in latest backoff (2.0.1)
from backoff.
This seems like a valid use case. Your suggested API is actually very similar to that of the giveup
keyword arg. So in that sense it doesn't seem out of place. giveup
is only supported on on_exception
decorator though - do you think on_predicate
would have such a compelling case? In general, I do try to keep them as similar as possible, but we would end up with the slightly odd API of in one case the function taking an Exception
arg and in the other an arbitrary value. Maybe that's not too weird though?
I have one other thought for an implementation which might be slicker, or maybe it wouldn't work... Although I haven't used the feature much, it's possible to send values to generators as well as yield from them. What if the backoff.expo
(or perhaps a replacement) generator supported receiving the exception or value itself? Any change would need to be backward compatible, and it's possible this just won't work since I haven't tried. If it did work though, this might be nicer than expanding API surface with another keyword arg. Thoughts?
from backoff.
I like the idea of sending the value to the generator, but also somewhat unfamiliar territory for me.
I'll play around with it a bit, I think it might be doable without breaking all current gen functions. Seems that send()
just does the same thing as next()
on a regular started generator unless the generator explicitly handles it.
Then possibly a custom wait_gen
could be used to do some stuff with exception.
I don't really have a good use case for on_predicate
in general right now, I'm more likely to just check the return value inline if needed and throw an exception, so no idea if and how people would use a feature like this with it.
from backoff.
Thanks.
Now that I'm thinking about, I think it's possible that the giveup
keyword arg could be better implemented this way too. If the wait_gen
generator received the exception or value it could do that "should I give up" introspection itself and return None
if so. The API actually wouldn't need to change to implement this, as the giveup
keyword would be passed along to wait_gen
on its instantiation (see how max_value
works).
If I'm losing you or confusing the point, don't worry about it. I'm thinking out loud here a bit. The point is that if your feature can be implemented with a send()
to the generator then perhaps giveup
can be implemented this way too.
from backoff.
is this closed by ed932f7?
from backoff.
Related Issues (20)
- Duplicate logging in some special cases HOT 1
- How do I use this?
- Obtain value returned by backoff_handler function after maximum tries is reached
- max_retries HOT 1
- max_time only applies _after_ first retry?
- Canonical way to handle error bursting
- Add exponential decay
- How to handle backoff on Facebook cursor? HOT 1
- Improve Typing and Error Handling in `on_exception`
- question about max_time
- Feature Request: add a way to use backoff in a context manager HOT 2
- feature request: toggle decorator on/off
- `backoff.on_predicate` does not work for `staticmethod`s
- Expose typing hints as they are part of the API
- Add support for globally disabling retries
- How to provide arguments to `on_backoff` function HOT 1
- Feature Request: support direct invocation with functools.partial
- Maintenance help? HOT 7
- README: `max_value` arg to `@backoff.on_predicate(backoff.fibo...)` -- if not obsolete, then maybe just confusing?
- Prevent error message in case of giveup using
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backoff.