Comments (5)
I guess the brute force way to do it would be to monkey patch backoff
's logger, but hoping for something cleaner. 🙈
from backoff.
I missed this issue when it came in. This seems like a reasonable request but any explicit support is something I'd have to think about more.
Rather than monkeypatch, you can supply your own logging function to backoff
via event handlers https://github.com/litl/backoff#event-handlers
You could imitate the default logger implementations here and have them use your adapter instead of the default backoff logger.
There's a few requests out there for more explicit customizable logging for backoff but I've been reluctant to do it thus far. For your use case, it might be as simple as providing a backoff.set_logger() method, but I'd have to think about it more.
from backoff.
I'm poking at the idea of adding a set_logger()
API function.
my_adapter = MyAdapter(logging.getLogger('backoff'))
backoff.set_logger(my_adapter)
Do you think that covers your use case?
from backoff.
Thanks for considering this feature!
The API looks reasonable, but it's not totally clear to me when an app should be setting backoff
's logger in this manner. For example, imagine the following app layout:
tmp$ tree
.
├── app.py
├── blueprints
│ └── api.py
└── lib
├── bar.py
└── foo.py
app.py
contains all the Flask init code. It is where we would also configure logging using logging.config.dictConfig
.
Each module has a module-level get_logger
call, right at the beginning:
from app import get_logger
logger = get_logger(__name__)
...
So in this example, if both api.py
and lib/foo.py
import backoff
and want to use it, when is it appropriate to call backoff.set_logger()
? It seems a bit weird for app.py
to import it and configure it at log configuration time, especially if app.py
never makes an explicit call using backoff
.
Anyway, perhaps I am just very confused on this topic, so in the interest of not blocking progress, I would say that providing that API makes sense, and I think app developers can make it all work. :)
Thanks again!
from backoff.
@achiang It's been a long time, but please check out #64 if you're still interested in this.
from backoff.
Related Issues (20)
- Duplicate logging in some special cases HOT 1
- How do I use this?
- Obtain value returned by backoff_handler function after maximum tries is reached
- max_retries HOT 1
- max_time only applies _after_ first retry?
- Canonical way to handle error bursting
- Add exponential decay
- How to handle backoff on Facebook cursor? HOT 1
- Improve Typing and Error Handling in `on_exception`
- question about max_time
- Feature Request: add a way to use backoff in a context manager HOT 2
- feature request: toggle decorator on/off
- `backoff.on_predicate` does not work for `staticmethod`s
- Expose typing hints as they are part of the API
- Add support for globally disabling retries
- How to provide arguments to `on_backoff` function HOT 1
- Feature Request: support direct invocation with functools.partial
- Maintenance help? HOT 7
- README: `max_value` arg to `@backoff.on_predicate(backoff.fibo...)` -- if not obsolete, then maybe just confusing?
- Prevent error message in case of giveup using
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backoff.