ljhgabe / pe

Sup 👋🏻

• 🌱 I'm Jiahe, a Computer Science + Applied Math DDP undergrad @ National University of Singapore
• 👀 My interest lies in quantitative finance and deep learning
• 📫 Reach me at [email protected] | [email protected]

pe's Issues

Select Index is not the one in the full list

Steps to reproduce: (a upper garment called name is in the fifth of the list)

1. find n/name
2. select 1
   Expected output: The first in the full list (it is not specified in UG) will be selected
   Actual output: The fifth one, which is the garment called name is selected.

UG lack of hyperlink to return to the feature list

As stated, it would be better if there is a hyperlink which returns to the feature list.

The matching rule is not clear

In ug, it is only mentioned that: Returns all the articles of clothing that match the colour and dress code of the garment at index 1 in the list of garments on display, and of different types.
However, user does not know what is evaluated as "match the colour" (Many people may not consider wearing the shirts, pants and shoes with exactly the same colour)

Match index is not the one in the full list

Steps to reproduce:
find blah (this will give an empty list)
match 1
Expected output: the garments matching the first garment in the list will be returned
Actual output: The index is invalid

Range of index is not specified correctly

Steps to reproduce: delete 99999999999999999999
Expected output: This index is out of range, or specify the range that is treated as INTEGER
Actual output: invalid command format: index must be a positive integer.

Dummy 1

No details provided.

Find command is not working as per UG

Steps to reproduce: find n/bla
Expected output: According to UG, garments with attributes that "contain" the specified keywords will be returned.
Actual output: Garment Blazer is not returned

Command not destroyed after use in diagram

There should be a cross sign under the DeleteCommand

Can select garment with the same type multiple times

As a user, i may need to select one upper garment per day. However, selecting multiple garments with the same type is allowed.

(The screen shot is taken after an upper garment has been selected)

Invalid prefix caused incorrect error message

Steps to reproduce: add n/favourite shirt s/20 colour/blue r/casual t/upper
Expected output: prefix "colour" is not valid, or invalid command
Actual output: size number should only contains...

Delete index is not the one in full list

Steps to reproduce:

1. find n/shirt
2. delete 1
   Expected output: the first garment after the list command, which is Blazer
   Actual output: the first shirt in the find n/shirt list is deleted

Verb form inconsistent in Use Cases

Duplicate arguments adding, only the second one is taken

Steps to reproduce: add n/favourite t shirt s/30 c/blue c/pink r/casual t/upper
Expected output: At least state in UG about this behaviour
Actual output: Only the second colour is taken

Edit index is not the one in list command

find shirt +
edit 1 n/new shirt
Expected: The first garment in the list command, which is blazer, is edited
Actual: The first garment in after find shirt command which is actually the second garment after list command is edited

Match with two indicies is misleading on UG

Steps to reproduce: match 1 2
Expected output: Returns all the articles of clothing that match the colours and dress code of the garments at indices 1 and 2 in the list of garments on display, and are of different types compared to the garments at indices 1 and 2.
Actual output: Invalid command format

(The features that yet be implemented should not be included in the example)

Missing extensions

The case when user find a garment before committing delete command is missing here.

Architecture diagram is too large

The architecture diagram is unnecessarily large.

Diagram too complicated and words are very small to view

View command is not very practical

As a user, the view command is too difficult to use in real practice. If all the input rules satisfied, one may already known what he/she is going to wear.

Broken link in DG

The Default Sorting Order cannot be clicked in the pdf provided