ljosa / cl-png Goto Github PK

http://www.schaik.com/pngsuite/tbbn0g04.png gets an alpha channel due to (png-set-expand png-ptr), but only 1 channel is allocated in the make-image call, so png-read-image writes past the end of the array.

Also, depending on options and file, both png-set-expand and png-set-strip-alpha are called, and the docs say

If you specify a contradictory set of transformations, for example both adding and removing the alpha channel, you cannot predict the final result.

(apply #'make-array
         (car args)
	 #+(or lispworks allegro) :allocation
	 #+lispworks :static #+allegro :static-reclaimable
	 (cdr args))

That is working on LispWorks. Probably on Allegro too, but I didn't check.

Found by running the tests of the quicklisp system "dataloader.test".

Building with SBCL 2.1.6 / ASDF 3.3.1 for quicklisp dist creation.

Trying to build commit id 11b965f

bmp-test fails to build because of a failure in png.

image-test fails to build because of a failure in png.

ops-test fails to build because of a failure in png.

png-test fails to build because of a failure in png.

png fails to build with the following error:

; caught ERROR:
;   READ error during COMPILE-FILE: Symbol "%ARRAY-DATA-VECTOR" not found in the SB-KERNEL package. Line: 26, Column: 50, File-Position: 1253 Stream: #<SB-INT:FORM-TRACKING-STREAM for "file /home/quicklisp/quicklisp-controller/dist/build-cache/cl-png/372e1d3889cf11ca32210874bec5b5fdf3140d61/cl-png-20210702-git/compat.lisp" {10094A4F33}>
...
Unhandled UIOP/LISP-BUILD:COMPILE-FILE-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING {1001A18103}>: COMPILE-FILE-ERROR while compiling #<CL-SOURCE-FILE "png" "compat">

Full log here