loginradius / dot-net-sdk Goto Github PK

it would be nice to have the appsettings as the conventions, we usually have appsettings.{Environment}.json, it seems the SDK is always getting appsettings.json only, it would be nice to have this differentiation as the configuration document below

https://docs.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-3.1

Suggestion

        public SDKConfigHandler()
        {
            var environment = Environment.GetEnvironmentVariable(BaseConstants.ASPNETCORE_ENVIRONMENT);

            var builder = new ConfigurationBuilder()
                .SetBasePath(Directory.GetCurrentDirectory())
                .AddJsonFile("appsettings.json", optional: true, reloadOnChange: true)
                .AddJsonFile($"appsettings.{environment}.json", optional: true, reloadOnChange: true)
                .AddEnvironmentVariables();

            Configuration = builder.Build();
        }

When I use this sdk and call
var apiResponse = new AuthenticationApi().VerifyEmail(token, null, url);

the apiResponse doesn't have any information of the user but when I call it native without this sdk, the response return me the email.

this is the response of the native call in a happy path

{
"IsPosted":true,
"Data":{
"Email":"[email protected]"
}
}

And I need the email to get the profile info

Dictionary concurency error in the ConfigManager.GetConfiguration() where two threads add the same key