Comments (4)
I believe the idea there is that TypedRoute
is not necessarily used from the same app where the route is pointing to. It can e.g. be used in UI test projects too, see TypedRouteUITestContextExtensions
. Thus, it can't (always) retrieve the target app's admin prefix. Right, @DAud-IcI?
from helpful-libraries.
Yes, it's like this for the sake of UI testing (here is the extension above mentioned). When I created TypedRoute
the UI-Testing-Toolbox still used a separate subprocess to run the webapp, so it was literally not possible to access configuration. I see that in the UITestContext
the admin prefix is still hard coded instead of loaded from the webapp being tested, so does that mean this is still not possible?
At any rate, if we want to load the admin prefix from configuration, we must make sure if falls back to the sensible default of "/Admin" gracefully and doesn't throw.
from helpful-libraries.
Indeed, in the UI Testing Toolbox we should access AdminOptions
, I created an issue for this here: Lombiq/UI-Testing-Toolbox#294
For the UITT use case we'll need to be able to optionally pass the prefix to `TypedRoute too.
from helpful-libraries.
For info, if AdminOptions
is not configured, the default value of AdminUrlPrefix
is Admin
.
from helpful-libraries.
Related Issues (19)
- Add locking to CacheServiceMonitor HOT 2
- Updated for 1.10? HOT 5
- Does not work in Orchard 1.9.x HOT 1
- Linq2db queries should only use transactions for write queries (OSOE-343) HOT 2
- Create `InvokeAsync` extension methods for `Task` returning delegates
- Split the Orchard Core specific methods into its own project (OSOE-70) HOT 4
- Add missing docs to public methods and Markdown files (OSOE-153) HOT 4
- Ability to use LinqToDb with the non-default collection HOT 7
- The existing field's DisplayName gets overwritten for no reason. (OSOE-474) HOT 7
- The collection being enumerated is modified inside the `foreach` loop. (OSOE-605)
- Make it possible to replace content items with an unknown ID using recipes (OSOE-648) HOT 3
- Relative URL prefixed with /Admin in case of an admin controller action if [Route] attribute is used (OSOE-653) HOT 4
- Enable nullable reference types in the solution and evaluate code (OSOE-754) HOT 3
- LinqQueryAsync throwing connection error if we setup Persist Security Info=False in connection string. (OSOE-801) HOT 5
- Add source generator that reads a JSON value as a const string at compile time. (OSOE-819) HOT 10
- Use source generation to create the `public partial class Program` needed by UITT (OSOE-829)
- Change the OC package references to 1.8.0 instead of 1.8.2 (OSOE-846) HOT 4
- New IDE0305 analyzer violation in `UseStrictAndSecureCookies()` (OSOE-854) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helpful-libraries.