Comments (10)
Yeah, I understood it as such. Just that we publish all of our open-source projects using package.jsons on NuGet, so that'll affect their NuGet publishing (e.g. https://github.com/Lombiq/Orchard-Chart.js, https://github.com/Lombiq/Orchard-Content-Editors, https://github.com/Lombiq/Orchard-Data-Tables).
from helpful-libraries.
Hmm, very interesting! This would be especially useful for updates done by Dependabot.
from helpful-libraries.
I've been looking into this issue and playing around with source generators as I've never worked on one before.
There are a few findings that I wanted to share here and get some feedback
The classes that will be marked with the attribute [ConstantFromJson("ChartJsVersion", "package.json", "$..['chart.js']")]
will need to be marked as partial: also see Source Generators cookbook
I am assuming that it won't be an issue to mark them as partial but wanted to just call it out.
Also in order to make the package.json file accessible to the generator it would have to be marked as an "AdditionalFiles" in the .csproj as source generators do not have access to the filesystem directly.
I am setting this up as a separate project within this repo for now, let me know if there are any thoughts around that.
from helpful-libraries.
Partial shouldn't be an issue, nor AdditionalFiles
I think but the latter also affects NuGet publishing. Perhaps it'd only result in an unnecessary file being bundled in the package, which is not a significant issue, but I don't know if it can break anything else.
from helpful-libraries.
Hey @Piedone,
The marking of the AdditionalFiles
is actually for the projects that will use the generator not on the generator itself. So the consuming projects would have to mark those files in their own .csproj so that the generator can access them at compile time
from helpful-libraries.
I get build errors locally with a fresh clone of OSOCE:
Repeated builds also fail.
from helpful-libraries.
The earlier OSOCE 509442daa9bdc7dc060d8a0196b8e803881af293
also shows this:
from helpful-libraries.
Considering that it works with dotnet
but not with VS, perhaps this is a VS bug. Then @AydinE please make a bug report.
from helpful-libraries.
Related Issues (17)
- Add locking to CacheServiceMonitor HOT 2
- Create `InvokeAsync` extension methods for `Task` returning delegates
- Split the Orchard Core specific methods into its own project (OSOE-70) HOT 4
- Add missing docs to public methods and Markdown files (OSOE-153) HOT 4
- Ability to use LinqToDb with the non-default collection HOT 7
- The existing field's DisplayName gets overwritten for no reason. (OSOE-474) HOT 7
- The collection being enumerated is modified inside the `foreach` loop. (OSOE-605)
- Make it possible to replace content items with an unknown ID using recipes (OSOE-648) HOT 3
- Updated for 1.10? HOT 5
- Relative URL prefixed with /Admin in case of an admin controller action if [Route] attribute is used (OSOE-653) HOT 4
- Retrive the Admin prefix from `AdminOptions.AdminUrlPrefix` instead of hardcoding it (OSOE-657) HOT 4
- Enable nullable reference types in the solution and evaluate code (OSOE-754) HOT 3
- LinqQueryAsync throwing connection error if we setup Persist Security Info=False in connection string. (OSOE-801) HOT 5
- Use source generation to create the `public partial class Program` needed by UITT (OSOE-829)
- Does not work in Orchard 1.9.x HOT 1
- Linq2db queries should only use transactions for write queries (OSOE-343) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helpful-libraries.