GithubHelp home page GithubHelp logo

asdf-hadolint's People

Contributors

crazy-matt avatar dependabot[bot] avatar github-actions[bot] avatar looztra avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

asdf-hadolint's Issues

Plugin fails to retrieve "latest" version

I was running into a weird issue where hadolint failed to install when using asdf:

Executing command: asdf plugin add hadolint && asdf install hadolint latest && asdf global hadolint latest                                   
hadolint  is already installed                                                                                                               
------------------------------                                                                                                               
Executing command: asdf list                                                                                                                 
hadolint                                                                                                                                     
  No versions installed                                                                                                                      
shellcheck                                                                                                                                   
  0.7.2           

After some troubleshooting, I found that putting literally anything except latest (or a valid version number) would appear to install that version:

$ asdf plugin add hadolint && asdf install hadolint foo && asdf global hadolint foo 
Downloading [hadolint] from https://github.com/hadolint/hadolint/releases/download/foo/hadolint-Linux-x86_64 to /tmp/asdf_hg0OhmYo/hadolint-Linux-x86_64
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0     31      0 --:--:-- --:--:-- --:--:--    31
Creating bin directory
Cleaning previous binaries
Copying binary

$ asdf list                                            
hadolint
  foo
shellcheck
  0.7.2

Unfortunately this just creates a text file with the contents Not Found:

$ hadolint --version
line 1: Not: command not found

$ cat ~/.asdf/installs/hadolint/foo/bin/hadolint 
Not Found%  

This is the output from asdf plugin test:

$ asdf plugin test hadolint https://github.com/looztra/asdf-hadolint
Updating hadolint to master
Already on 'master'
Your branch is up to date with 'origin/master'.
hadolint/bin/list-all is using GitHub API, just be sure you provide an API Authorization token
via your CI env GITHUB_API_TOKEN. This is the current rate_limit:

{
  "resources": {
    "core": {
      "limit": 60,
      "remaining": 38,
      "reset": 1635982930,
      "used": 22,
      "resource": "core"
    },
    "graphql": {
      "limit": 0,
      "remaining": 0,
      "reset": 1635985287,
      "used": 0,
      "resource": "graphql"
    },
    "integration_manifest": {
      "limit": 5000,
      "remaining": 5000,
      "reset": 1635985287,
      "used": 0,
      "resource": "integration_manifest"
    },
    "search": {
      "limit": 10,
      "remaining": 10,
      "reset": 1635981747,
      "used": 0,
      "resource": "search"
    }
  },
  "rate": {
    "limit": 60,
    "remaining": 38,
    "reset": 1635982930,
    "used": 22,
    "resource": "core"
  }
}

FAILED: could not get latest version

I also have shellcheck installed and it works as expected. I did notice a few differences between the two plugins, with the most obvious differences here:

https://github.com/luizm/asdf-shellcheck/blob/2c72b1f6a4012e91900a6e7438578abce8ab2013/bin/list-all#L16-L19

https://github.com/luizm/asdf-shellcheck/blob/2c72b1f6a4012e91900a6e7438578abce8ab2013/bin/install#L4

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.