ls- / ls_toasts Goto Github PK

Hi!
Dragonflight added reagent quality to most of the crafting reagents, it would be nice if Ls_Toasts showed reagent quality the same way when they're collected (there already exist a modifier adding stars to the toast thumbnail, but they don't seem to work for reagent gathering ? It would also be better to now use the same icons as the game)

As another feature, it would be nice to have more modifiers on different new crafting related procs (finesse, perception, inspiration, resourcefulness, multicraft)

Hi and thanks for your great AddOn.

I want to request rarity support, here is a example, in the top left: http://i.imgur.com/XGHE0K7.jpg

Kind regards

Started getting the error this morning, also can't pull up the settings.

Message: Interface\AddOns\ls_Toasts\init.lua:311: Attempt to unregister unknown event "ACHIEVEMENT_EARNED"
Time: Thu Sep 5 12:16:11 2019
Count: 1
Stack: Interface\AddOns\ls_Toasts\init.lua:311: Attempt to unregister unknown event "ACHIEVEMENT_EARNED"
[C]: in function UnregisterEvent' Interface\AddOns\ls_Toasts\init.lua:311: in function func'
Interface\AddOns\ls_Toasts\core\core.lua:42: in function <Interface\AddOns\ls_Toasts\core\core.lua:40>

Locals: (*temporary) = AlertFrame {
0 =
SetSubSystemAnchorPriority = defined @interface\FrameXML\AlertFrames.lua:350
BuildQuestData = defined @interface\FrameXML\AlertFrames.lua:632
shouldQueueAlertsFlags =

{
}
SetJustification = defined @interface\FrameXML\AlertFrames.lua:377
CreateSubSystem = defined @interface\FrameXML\AlertFrames.lua:311
CreateQueuedSubSystem = defined @interface\FrameXML\AlertFrames.lua:328
SetEnabledFlag = defined @interface\FrameXML\AlertFrames.lua:277
SetVariablesLoaded = defined @interface\FrameXML\AlertFrames.lua:294
GetPointsForJustification = defined @interface\FrameXML\AlertFrames.lua:402
SetAlertsEnabled = defined @interface\FrameXML\AlertFrames.lua:299
BuildLFGRewardData = defined @interface\FrameXML\AlertFrames.lua:590
AreAlertsEnabled = defined @interface\FrameXML\AlertFrames.lua:303
AddQueuedAlertFrameSubSystem = defined @interface\FrameXML\AlertFrames.lua:338
AddAlertFrameSubSystem = defined @interface\FrameXML\AlertFrames.lua:342
GetJustification = defined @interface\FrameXML\AlertFrames.lua:384
anchorPrioritiesDirty = true
OnLoad = defined @interface\FrameXML\AlertFrames.lua:417
CleanAnchorPriorities = defined @interface\FrameXML\AlertFrames.lua:360
AddExternallyAnchoredSubSystem = defined @interface\FrameXML\AlertFrames.lua:318
ShouldSupressDungeonOrScenarioAlert = defined @interface\FrameXML\AlertFrames.lua:658
OnEvent = defined @interface\FrameXML\AlertFrames.lua:423
AddAutoAnchoredSubSystem = defined @interface\FrameXML\AlertFrames.lua:323
BuildScenarioRewardData = defined @interface\FrameXML\AlertFrames.lua:622
AddSimpleAlertFrameSubSystem = defined @interface\FrameXML\AlertFrames.lua:332
SetPlayerEnteredWorld = defined @interface\FrameXML\AlertFrames.lua:289
alertFrameSubSystems = {
}
UpdateAnchors = defined @interface\FrameXML\AlertFrames.lua:368
ignoreFramePositionManager = true
AddAlertFrame = defined @interface\FrameXML\AlertFrames.lua:409
}
(*temporary) = "ACHIEVEMENT_EARNED"

Hey, great addon! One of those that I didn't know I needed until it was downloaded.

I'm now using this instead of the chat log (using it for all items), and felt like it would a good addition to show total count of an item aswell somehow.

Hey. As of today's update for Retail (10.0.2) I'm getting this lua error whenever I load into the game:

1x Interface/AddOns/ls_Toasts/core/core.lua:247: attempt to call global 'IsDressableItem' (a nil value)
[string "@Interface/AddOns/ls_Toasts/core/core.lua"]:247: in function `DressUpLink'
[string "@Interface/AddOns/ls_Toasts/systems/loot_special.lua"]:21: in function <Interface/AddOns/ls_Toasts/systems/loot_special.lua:19>
[string "=[C]"]: ?

Locals:
self =

• Added leaf ornaments to achievement toasts. I can't re-enable Blizz achievement toasts, so as a
  compromise I chose to make achievement toasts more unique. If you want them to stand out even more
  create a separate anchor to display them.
• Fixed an issue where repeatedly testing toasts and flushing the queue would sometimes lock up the
  addon.
• Fixed corrupt beautycase border texture. It worked, but baked-in shadows were messed up.
• Updated Traditional Chinese translation. Translated by BNS333@Curse.
  "
  RegisterCallback = defined @Interface/AddOns/Masque/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:85
  VER =

Hello,

It seems the addon it returns a lua error when I complete tank call to arms (satchel) dungeons.

`Message: Interface\AddOns\ls_Toasts\ls_Toasts.lua:931: attempt to call method 'SetLFGCompletionReward' (a nil value)

hello there, I was wondering whether we could get optional more squarish-texures for people using something like elvui, since the rounded edges look weird in the clean style... I would love that! =)

When you queue for the epic battleground Ashran and are near other players you get spammed with artifact fragments toasts every few seconds. You get the toasts as normal when you loot a fragment but it seems being around other players also shows a toast whether or not you looted one.

Version: 80200.05
Happens in older versions as well, not sure what version it started in.

I Use this addon since WoD and cannot live without it. There is a way to add toast for reputation changes?

Hello Senior,

first of all, thank you for the new skinning function for ls_Toast. But i have an issue if you set the scale to 0.9, then the right border seems to be cut off. With the default skin it looks fine, but even with the implement ElvUI skin, it get cut off:

See Screenshots
Scale 1.0 (fine)

Scale 0.9 (cut off)

btw. here is the code to my skin: https://git.tukui.org/Merathilis/ElvUI_MerathilisUI/blob/development/ElvUI_MerathilisUI/modules/skins/addons/ls_Toasts.lua

I don't know if this is even in the spirit of the addon, but personally it would be very useful to get a toast when a reputation change occurs.

Maybe as an on/off option for those that would it spammy?

Hi, I made a skin for ls_Toasts and loaded it by default, but it was broken in the latest version. I noticed that addonTable.C is no longer exposed to global environment, because the load order was changed in _core.xml.

Any plan to fix this? Thanks.

As it is right now, it's popping up a toast window for almost every non-grey item that I loot. Is there a way to change that? I don't need toast windows for every quest item or bit of currency that I loot.

Ideally, I'd only want toasts for AP items, and rare/epic items.

The wlk version will cause the Blizzard native prompt box to disappear!
Cancelling the achievement prompt cannot be restored, it can only be disabled!

I think it would be quite nice to be able to show a toast whenever quest loot is picked up.

Couldn't open Interface\AddOns\ls_Toasts-sqw
Time: Thu Aug 30 07:06:34 2018
Count: 3

Hi!

I'd love to get a toast for Experience Gains and Reputation Gains.

I have them in chat now but I would like a toast instead :-)

Edit: You could do fancy stuff like "repetitions to level" and "repetitions to new Reputation level (revered, exalted, etc)".

gr,

Tom

Hey there,

can you please check these lua errors? They pop up at login, and the commands /lst & /lstoasts does not work, with all addons disabled.

Version: 70300.07

Message: ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:7: Cannot find a library instance of "AceGUI-3.0".
Time: 02/16/18 11:29:03
Count: 1
Stack: ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:7: Cannot find a library instance of "AceGUI-3.0".
[C]: ?
[C]: in function error' ...nterface\AddOns\SharedMedia\libs\LibStub\LibStub.lua:38: in function LibStub'
...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:7: in main chunk

Locals:

Message: Interface\AddOns\ls_Toasts\init.lua:306: Cannot find a library instance of "AceConfigDialog-3.0".
Time: 02/16/18 11:29:04
Count: 1
Stack: Interface\AddOns\ls_Toasts\init.lua:306: Cannot find a library instance of "AceConfigDialog-3.0".
[C]: ?
[C]: in function error' ...nterface\AddOns\SharedMedia\libs\LibStub\LibStub.lua:38: in function LibStub'
Interface\AddOns\ls_Toasts\init.lua:306: in function `func'
Interface\AddOns\ls_Toasts\core\core.lua:33: in function <Interface\AddOns\ls_Toasts\core\core.lua:31>

Locals:

1x Usage: local sources = C_TransmogCollection.GetAppearanceSources(appearanceID)
[C]: in function GetAppearanceSources' ls_Toasts\ls_Toasts-70200.01.lua:2617: in function <ls_Toasts\ls_Toasts.lua:2615> ls_Toasts\ls_Toasts-70200.01.lua:2662: in function ?'
ls_Toasts\ls_Toasts-70200.01.lua:195: in function <ls_Toasts\ls_Toasts.lua:194>

Locals:
(*temporary) = "Usage: local sources = C_TransmogCollection.GetAppearanceSources(appearanceID)"

I think it should be showing that I lost the currency instead of gaining, but it would also be great if I could turn off the currency spending like with gold.

See recording: https://i.imgur.com/zfQ6EM7.mp4
Here with less "gain" due to fragment reducing cost: https://i.imgur.com/dZgNzDj.mp4

I see you tried to address this before, but I cannot see your options menu. I use SUF instead of the default raid frames.

Fresh install of version 1.23 via the Curse Client.

/lstoasts opens the options window, but ls_Toasts is not listed.

Not sure if this is a bug or a design choice, but whenever I gain a currency (Order Resources for example) it will show a few seconds after obtaining.

I've disabled the "DND" feature thinking it might be combat related, but that didn't solve it.

This also happens when Currency is the only Toast being displayed, for example picking up Garrison Resources from WoD's Garrison Cache.

This is happening with v1.11 and v1.12, and no other addons enabled.

1x ls_Toasts/systems/garrison.lua:70: attempt to index field '?' (a nil value)
[string "@ls_Toasts/systems/garrison.lua"]:70: in function `func'
[string "@ls_Toasts/core/core.lua"]:35: in function <ls_Toasts/core/core.lua:33>

Locals:
followerTypeID = 123
missionID = 2205
garrisonType = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field '?' (a nil value)"
getGarrisonTypeByFollowerType = defined @ls_Toasts/systems/garrison.lua:21
C =

Hi, I was trying to install your addon via WoWup and it installs all but the Retail Files. I am not sure why, as I don't understand the full details, but the WoWup discord has alot of people who do and will help.

Since 9.0.2 im often seeing the popup msg and its showing me the currency i just used. Easy example: When bonus rolling something i see the popup msg with +1 the currency.

I tried adding the ID and it does find it but it does not let me add the code for it. Basically I cannot click ADD.

Foxflower from the random fox that spawns can generate 20-30 toasts in a few seconds. Would be cool if it were possible to display a running total on a single toast as I loot multiple foxflower. Another example would be ancient mana in Suramar.

Having an odd issue when using this with ElvUI, parts of the achievement skin aren't working,

standard ElvUI: http://i.imgur.com/qrO8aJh.jpg

ElvUI + ls_Toasts: http://i.imgur.com/JRg6aW8.jpg

As you can see, the achivement frame itself isn't skinned anymore, as well as some sliders and dropdowns.

Is this something you can fix, or do I need to contact ElvUI authors about this?

Thanks for your great work!

I know it's impossible to enable the default blizzard skin for only achievements, but is it possible to add a skin that makes everything have the default achievement look?

The default achievement toast is almost too nostalgic to get rid of for me, but everything else about this addon is so perfect

Hi, getting the following error in 10.1 on retail, using version 100100.01:

8x ls_Toasts/systems/world.lua:109: attempt to compare number with nil [string "@ls_Toasts/systems/world.lua"]:109: in function <ls_Toasts/systems/world.lua:30> [string "@ls_Toasts/systems/world.lua"]:167: in function <ls_Toasts/systems/world.lua:158> [string "@ls_Toasts/systems/world.lua"]:181: in function func'
[string "@ls_Toasts/core/core.lua"]:35: in function <ls_Toasts/core/core.lua:33>

Locals:
event = "QUEST_TURNED_IN"
isUpdate = false
questID = 75705
name = "Monument Maintenance"
moneyReward = 0
xpReward = 0
numCurrencyRewards = 0
itemReward = nil
toast = LSToast1 {
0 =
IconText2 = FontString {
}
BG = Texture {
}
TextBG = Texture {
}
Arrow5 = Texture {
}
IconBorder =

Whenever I try to join a BG with the Group Finder the following error triggers. Blizzard warns about disabling the addon, actually it is the only way to join a BG.

`3x [ADDON_ACTION_FORBIDDEN] AddOn 'ls_Toasts' tried to call the protected function 'JoinBattlefield()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function "JoinBattlefield"
Blizzard_PVPUI\Blizzard_PVPUI-1.0.lua:551: in function "HonorFrame_Queue"
[string ":OnClick"]:2: in function <[string ":OnClick"]:1>

Locals:
nil`

With the latest addon update, I've just noticed the gold toast.
My suggestion is to add a threshold for each of the gold earned and gold spent. In its current state it's too spammy, showing up everytime I post something on AH. I'd probably set the treshold myself to 10k, with the purpose of only notifying me for big earnings/big spendings.

Latest version of Is: Toasts
2x Attempt to register unknown event "RAF_ENTITLEMENT_DELIVERED"
[C]: ?
[C]: ?
ls_Toasts\core\core.lua:117: in function Call' ls_Toasts\core\core.lua:71: in function RegisterEvent'
ls_Toasts\systems\store.lua:168: in function Enable' ls_Toasts\core\system.lua:75: in function EnableAllSystems'
ls_Toasts\init.lua:325: in function `func'
ls_Toasts\core\core.lua:48: in function <ls_Toasts\core\core.lua:46>

Right-clicking the toast for the "Ominous Conch" causes it to be used

Toasts is not showing scrapped loot anymore. It used to and was awesome. It could be I missed a setting or something. Please Help. Nice addon by the way.!

update looks like cloth items. I am still trying to figure it out.

Would love to have a selectable option to display total item count alongside the count of items just looted.

For example, if catching a bass while I've already got ten of the same fish in my bag, seeing something like "+1 (11)" on the toast would be helpful.

Hello, I have a question or request.

I had seen that my friend always uses 2 or even 3 frames. One for just loot, another for just gold, etc. He travels a lot in the AH.

I have set it up that way and have 2 frames. One that shows the "general loot" and is scaled slightly smaller. And a frame for everything else that is scaled larger.

Now my question/request: Could you add the option that you could adjust the font size depending on the frame? Since I have scaled both frames differently and you only adjust the font size for all frames with "general", the font size is then too big in the small frame or too small in the large frame.

I hope you understand what I mean. Or did I miss the option?

PS: Thanks for the great work.

http://i.imgur.com/pRKXXyK.jpg

I've noticed this here, every time I get more than 1 appearance added, on some item the text won't show.
Using 1.15

Hej!

I really enjoy your addon... it's great and already recommend it to some guild mates!
But I still like the blizzard default toasts for achievements (are they called toasts?) and I would like to keep them together with the other toasts from your addon... is this possible?
If I deactivate achievement toasts from your addon I don't get (achievement) toasts at all :-/

thank you very much!

I wish add a feature, coloring item name text by quality

Hey there,

Is there a way to inject a custom toast (eg. extending the existing system via another addon etc)? It looks like all the methods needed are private inside of the addon namespace :(

Transmogs don't currently toggle a toast when you learn an appearance, but I was able to use your code to create a toast for them. The majority of the additions are just copying and adapting the existing Achievement coding.

ls_toasts.lua:43

transmog = false, -- transmog appearances

ls_toasts.lua:52

  transmog_enabled = true,

ls_toasts.lua:951-1008

--------------
-- TRANSMOG --
--------------

local function TransmogToast_SetUp(vID)
local toast = GetToast("misc")
--This if/end is used only for the test scenario.
--A vID will not be passed to the main function during regular use.
local visualID
if vID then visualID = vID else
  visualID = C_TransmogCollection.GetLatestAppearance()
end
if visualID then
  local sources
  sources = C_TransmogCollection.GetAppearanceSources(visualID)
  for i=1,#sources do
-- Many appearances have multiple sources, so we need to match those with possible items
    sID = sources[i].sourceID
    _,_,_,_,_,sLink,aLink = C_TransmogCollection.GetAppearanceSourceInfo(sID)
-- We assume the item is in the player's inventory, since it was just added to the collection
    if GetItemCount(sLink) == 1 then
      break
    end
  end
  _,_,_,_,_,_,_,_,_,icon = GetItemInfo(sLink)

  toast.Title:SetText("Appearance Added!")
  toast.Text:SetText(sLink)

  toast.Border:SetVertexColor(1, 1, 1)
  toast.IconBorder:SetVertexColor(1, 1, 1)
  toast.Icon:SetTexture(icon)
  toast.link = aLink
else
--Currently, there is no way to know what appearance was removed
--unless we cache the player's inventory. The only way for appearances
--to be removed is by trading raid loot or returning alternate-currency
--items to a vendor, both within the 2 hour time limit.
  toast.Title:SetText("Appearance Removed!")
  toast.Text:SetText("Check recent sales/trades")

  toast.Border:SetVertexColor(1, 1, 1)
  toast.IconBorder:SetVertexColor(1, 1, 1)
  toast.Icon:SetTexture(134400)
end

SpawnToast(toast, CFG.dnd.transmog)
end

function dispatcher:TRANSMOG_COLLECTION_UPDATED(...)
--vID is only used here for the testing function later.  
  vID = ...
  TransmogToast_SetUp(vID)

end

local function EnableTransmogToasts()

  if CFG.transmog_enabled then
    dispatcher:RegisterEvent("TRANSMOG_COLLECTION_UPDATED")
  end
end

local function DisableTransmogToasts()
  dispatcher:UnregisterEvent("TRANSMOG_COLLECTION_UPDATED")
end

ls_toasts.lua:1865-1869

local function SpawnTestTransmogToast()
--This event doesn't actually send an appearanceID, but we are faking it for this test.
--Note that the first time the player runs this test, the toast will be empty
--because the item has not been cached yet.
--This wouldn't happen in normal operations because the item
--is already in our bags when we create the toast.
  dispatcher:TRANSMOG_COLLECTION_UPDATED(24799)
end

ls_toasts.lua:2131-2136

  elseif value == "transmog_enabled" then
    if state then
      EnableTransmogToasts()
    else
      DisableTransmogToasts()
    end

ls_toasts.lua:2536
Change height of panel to accomodate the addition of the Appearances line

  toastSettings:SetSize(441, 191)

ls_toasts.lua:2562-2565
Add Appearances to the config window, change for statement to include an 8th option

  [8] = {name = "Appearances", point = {"TOPLEFT", toastSettings, "TOPLEFT", 2, -173}, enabled = "transmog_enabled", dnd = "dnd.transmog", testFunc = SpawnTestTransmogToast},
}

for i = 1, 8 do
[...]

ls_toasts.lua:2628

  EnableTransmogToasts()

I would like to have the toast show the Collections window when clicked, but I couldn't figure out how to make that happen. I'd also like to have the toast use a different image for the background, possibly incorporating the EtherealLines.blp that is in the 'BlizzardInterfaceArt\Interface\Transmogrify' folder.

I've just installed the newest version. /LST or /LSTOASTS does'nt work .. Can't see other ways to access it.

1x [ADDON_ACTION_BLOCKED] AddOn 'ls_Toasts' hat versucht die geschützte Funktion 'CompactPartyFrame:unusedFunc()' aufzurufen.
[string "@!BugGrabber\BugGrabber.lua"]:519: in function <!BugGrabber\BugGrabber.lua:519>
[string "=[C]"]: in function unusedFunc' [string "@Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua"]:160: in function CompactRaidFrameContainer_LayoutFrames'
[string "@Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua"]:130: in function CompactRaidFrameContainer_TryUpdate' [string "@Blizzard_CompactRaidFrames\Blizzard_CompactRaidFrameContainer.lua"]:57: in function CompactRaidFrameContainer_OnEvent'
[string ":OnEvent"]:1: in function <[string ":OnEvent"]:1>

So it could just be my setup but I cannot move the location of Toasts. Even though on ElvUi I have it set to center. It still shows up in upper left hand corner of my screen.

While tailoring my new UI I decided it would be best to move QuestTalkingHeadFrame with Moveanything to the center left corner because it's in the way on it's original position, while trying this out it became clear to me that the worldquest reward toasts were anchored to QuestTalkingHeadFrame in some way (because it started out in the middle, then popped up over QuestTalkingHeadFrame as soon as it appeared)

Pictured: http://cubeupload.com/im/QRLeEm.jpg

A friend recommended lstoasts because it had one single controllable anchor, but it still seems to clash with this behavior.

Pictured: http://cubeupload.com/im/2d59Dr.jpg (the anchor is supposed to be at the bottom here)
Anchor: http://cubeupload.com/im/X21jfE.jpg (it does not fix itself after a /reload)

I shall reinstall and reload after configuring, because I'm not sure i did the first time around. But it seems that the anchor is "corrupted" after being logged in for a while.
I'm not sure that this is an Issue with lstoasts, but i thought that I should share with you either way.

Hello i download the Ls_Toasts>wotlk/master>
But its not loaded in addons it not read it ingame no commands or Interface menu shows

I'd love to be able to disable guild achievements as there appears to be a UI bug where some old guild achievements re-pop from time to time.
At the moment this doesn't appear to be possible in LS Toasts as guild and personal achievements aren't separated, hence I'm requesting the separation of these so each type can be configured to the users liking.