lukasss93 / laravel-larex

Laravel Larex lets you translate your whole Laravel application with a single CSV file.

Hi there 👋

I'm a Full-Stack Developer working in Milan, Italy.

• 🌱 Learning all about Open Source
• ⚙ I use daily .php, .js, .html, .css, .scss, .ts, .hb, .psd
• 🔨 I’m working on laravel-larex, telegrambot-php, etc...
• 📫 How to reach me: twitter.com/Lukasss93, t.me/Lukasss93
• ⚡ Fun fact: I'm a huge fan of Harry Potter and MCU

laravel-larex's Issues

Using of var_export method

Change the writeKeyValue method to var_export method to fix possible bugs.

Not standard csv file

The current csv delimiter is ";" instead of ",".
It's necessary to change it to support standard csv files provided by external programs like google sheets, etc...

Invalid escaping on export command

Value on CSV:

group;key;en
app;example;This is a \"string\"

Value after export command:

// resources/lang/en/app.php
<?php

return [
    'example' => 'This is a \"string\"'
];

How it should be:

// resources/lang/en/app.php
<?php

return [
    'example' => 'This is a "string"'
];

Insert command has problems with utf-8 characters

When I insert UTF-8 chars using the insert command, this is what i get:

No way of ordering languages with import command.

The larex:import command orders languages alphabetically to the CSV.
How can you order them differently?
In my case using the larex crowdin plugin that wants the third key to be the source language and my file: group,key,af,am,ar,en

Wrong export message

Wrong export message when lang folder is inside project root (laravel 9)

wrong export

if the last column has a single space without enclosure, it will not be exported.

Using translation strings as keys is not supported

https://laravel.com/docs/8.x/localization#using-translation-strings-as-keys

Change commands export/import

The commands larex:export and larex:import could be confusing to users.

Possible solutions:

• Replace larex:export with larex:build:lang and larex:import with larex:build:csv
• Add larex:build:lang as alias for larex:export and larex:build:csv as alias for larex:import

Wrong enclosure with larex:insert

The larex:insert command add wrong enclosure if there is a quotation mark with a comma.

Example:

Input:
test "cool" and, oops

Output:
""test ""cool"" and, oops""

Expected:
"test ""cool"" and, oops"

Add support for "Overriding Package Language Files"

https://laravel.com/docs/9.x/localization#overriding-package-language-files

Which path to take?

A) Create another localization.csv for every package inside /lang/vendor/. Example:

• /lang/vendor/packageA/localization.csv
• /lang/vendor/packageB/localization.csv

B) Use the default localization.csv file using an alias prefix in the larex.php config

// <project-root>/config/larex.php

'vendor' => [
    'enabled' => false,
    'prefix' => 'vendor',
    'alias' => [
        'packageA' => 'a',
        'packageB' => 'b',
    ]
]

group	key	en	it
vendor.a.app	car	Car	Auto
vendor.b.common	hello	Hello	Ciao

Sentences with line break aren't escaped!

Input:

group;key;en
app;test;test
app;hello;"hello
friends"
app;ok;ok

After larex:sort (missing escaping):

group;key;en
app;hello;hello
friends
app;ok;ok
app;test;test

Duplicate lint message

This bug is caused when there are >=2 parameters in the localization string.

Unable to create localization.csv if folder doesn't exist

Note
Create folders recursively