lukemcdonald / holly-react Goto Github PK

I'm wondering where the logic for detecting whether emails contain an "@", etc. is hidden.

I don't see it inside NewsletterForm like I'd expect.

I want to modify it because I don't like that it throws an error message at users who forgot an "@" after they type every character.

Hello @lukemcdonald !

The result is different from the example when cloned and executed. What should I do? (attached a screenshot.)
would be very grateful if you could answer.

Sincerely,
dayrain

.

Is there an existing issue for this?

• Yes, I have searched the existing issues.

Description of the bug

Looking for directory that doesn't exists and fails when running npm start

PS C:\git\testapp\app> npm start

[email protected] start
NODE_PATH=./src npm-run-all -p watch:css start:js

'NODE_PATH' is not recognized as an internal or external command,
operable program or batch file.
PS C:\git\testapp\app> npm start

[email protected] start
npm-run-all -p watch:css start:js

[email protected] start:js
react-scripts start

[email protected] watch:css
watch 'npm run build:css' src/assets/css/theme

Watching run
Watching build:css'
Watching src/assets/css/theme
C:\git\testapp\app\node_modules@cnakazawa\watch\main.js:73
if (err) throw err;
^

[Error: ENOENT: no such file or directory, stat 'C:\git\testapp\app\run'] {
errno: -4058,
code: 'ENOENT',
syscall: 'stat',
path: 'C:\git\testapp\app\run'
}
ERROR: "watch:css" exited with 1.

Steps to Reproduce

Clone repo
npm install
npm start

Additional Information

None

Hello Luke,

I love the repo and have been able to use it to help improve my skills by customizing the site (I am new to React and JS). I have a quick question for you -- when I change the style.css file, it is reflected on the local version of my website, but as soon as I run NPM start again, that file is overwritten with the original version, and my changes are lost. Do you know how I can fix this so the changes I make to the style.css file are not overwritten?

Thanks so much!
Justin

I want to deploy this on heroku, what would the script be to start the production server?