lumina-tech / gooq Goto Github PK

see

see

INSERT INTO public.table1 (column1, column2, column3, column4) VALUES ($1, $2, $3, $4) ($5, $6, $7, $8)

From https://github.com/lumina-tech/gOOQ/blob/master/pkg/gooq/insert_test.go#L25 is supposed to be

INSERT INTO public.table1 (column1, column2, column3, column4) VALUES ($1, $2, $3, $4), ($5, $6, $7, $8)

(See https://www.postgresqltutorial.com/postgresql-insert-multiple-rows/)

I think the issue can be fixed by just changing " " to ", " here: https://github.com/lumina-tech/gOOQ/blob/master/pkg/gooq/insert.go#L256

I'll experiment and make an MR some time

Hi there.

I'm happy to see that you apparently liked jOOQ so much that you decided to create a clone in Go.

There's absolutely nothing wrong with porting a library / idea to some other platform, but I can't say I like your product being called "gOOQ". jOOQ is a registered trademark (in some countries), and your spelling, and also your spelled out name "Golang Object Oriented Querying" infringes this trademark.

The fact that you're calling your product gOOQ makes it seem as though I had anything to do with it, or even endorse it, which I don't. Think of it this way: I spent the last 11 years building this brand, and it's not OK to use this brand without my permission.

It's not too late yet. I think it would be a good idea to rename your product to something of your own creation.

Thanks,
Lukas

see

see:

https://www.postgresql.org/docs/12/queries-table-expressions.html#QUERIES-GROUPING-SETS

https://www.postgresql.org/docs/12/sql-insert.html

gOOQ's SELECT currently does not support the HAVING clause: https://github.com/lumina-tech/gOOQ/blob/master/pkg/gooq/select.go#L285

Here is a code snippet that currently panics, because HAVING is not implemented:

gooq.Select(gooq.Count(model.Person.ID)).
	GroupBy(model.Person.BirthYear).
	Having(model.Person.BirthYear.Gt(gooq.String("1995")))

Currently running gooq generate-database-models will try to run a "dockerized" database. This behaviour is usually only desirable for testing purposes, and should not be the default.

extend swapi example - https://github.com/lumina-tech/gOOQ/tree/master/examples/swapi

https://www.postgresql.org/docs/12/sql-select.html#SQL-FOR-UPDATE-SHARE

https://www.postgresql.org/docs/12/sql-select.html#SQL-UNION

https://www.postgresql.org/docs/12/sql-update.html

see

see

https://www.postgresql.org/docs/12/sql-select.html#SQL-DISTINCT

https://www.postgresql.org/docs/12/sql-select.html#SQL-WINDOW

Users can specify what folder should store the generated tables and the models (i.e. modelPath and tablePath in gooq.yml).

The package names for the generated files are hardcoded to model and table; if a user sets the modelPath to, say, models, then there will be a mismatch between the directory name and the package name.

Ideally if the gooq.yml has the following key set:

modelPath: "models"

Then the files in the models/ directory should be in a package called models.

extends swapi example - https://github.com/lumina-tech/gOOQ/tree/master/examples/swapi

Running go get github.com/lumina-tech/gooq/cmd installs the gOOQ generator binary as cmd.

The name of the binary is determined by last item in the URI path. Other projects work (such as go-ethereum) around this by having the following directory structure: repo/cmd/mycli/main.go

Fix coming soon.

• add section on Getting Started to ensure smooth onboarding
• add section explaining how code generation work
• add section explaining benefit of having type safe SQL

https://www.postgresql.org/docs/12/sql-delete.html

Currently marshaling models that have jsonb fields outputs the base64 encoding of those fields. To output json instead:

nullable.Jsonb should implement MarshalJSON/UnmarshalJSON and non-nullable jsonb columns should be generated as json.RawMessage rather than []byte.

https://github.com/lumina-tech/gOOQ/blob/e7f49a8e89eb11e7b9de65b17a23e2b7c8d28303/pkg/nullable/jsonb.go