lunarmodules / luaexpat Goto Github PK

Currently, luaexpat always parses standard XML entities into their corresponding characters. While this is convenient for most applications, it inhibits creating programs that preserve entity encoding when serializing a document. expat provides for the XML_SetParamEntityParsing function to control whether it parses entities, and it would be useful to expose control over this functionality in LuaExpat, maybe as a parser:setentityparsing function.

Trying to bump a luaexpeat dependency on something in Homebrew I ran into trouble moving to 1.5.x because for whatever reason even the newer versions of libExpat don't supply expat_config.h as expected.

See Homebrew/homebrew-core#114831 (comment)

This may be something upstream in libExpat, or it could be just an expectation that luaexpat needs to adjust.

Hi!

It would be nice if…

…could maybe include both Expat versions 2.4.4 and the latest 2.6.2 via the matrix. Patching that would also show if CI is still green today. What do you think?

Best, Sebastian

It would be useful to have a user-definable data table attached to the parser, which would be visible to any callbacks called by that parser. This would help avoid the use of global variables. It seems like such a table could live in the lxp_userdata structure.

I have no experience with c/lua interoperation, so I don't know how hard this would be, but I'm willing to try to implement this.

@mwild1 what would be required for a new release?

What I've noticed;

• links in the documentation need updating [done, see #7]
• this repo has release 1.2.0 and 1.3.0 (tags), yet README.md has 1.4.0... In the mailing list was mentioned 1.4.0 was to be released soon (tm) [done, see discussion below and #7]
• LuaRocks has release 1.3.3 as latest [done, see discussion below]
• Ownership of LuaRocks is with @tomasguisasola currently. Should that stay?
• are there differences between @tomasguisasola released 1.3.3 and the current repo, that might break user expectations? [done, see discussion below and #7]
• Document the totable.lua module, done in pr #10, waits for merge
• PR #3
• Do we keep the ancient VC6 files around? PR #12
• chaining calls; PR #15
• XmlDecl bugfix; PR #16
• additional handlers implemented; Pr #17

Any other concerns or things that need fixing/updating?

EDIT: updated status on the items listed

Since current repository is now considered official, please make new tag that distinguish new changes since 1.3.0 is made by old repo.

I've been doing some work on an XML DOM (level 2) implementation, since we decided to drop XML support from Penlight.

Would the LuaExpat library be a good place for that? It would make the library more complete, and a one stop shop for XML needs probably. But it would require more maintenance probably to add something like that (assuming there will be a bunch of initial issues that need to be ironed out over time)

Thoughts @mwild1 @tomasguisasola ?