lunarmodules / moon-sand Goto Github PK

This line:

There is a difference between tagged versions and development rocks.

1. The tagged versions should never be uploaded with --force, if they change the author should increment the rockspec revision. And if he/she doesn't, then I think it should fail to upload.

2. The dev versions (dev, scm and the likes instead of 2.3.1 for example) should have the flag --skip-pack to only upload the rockspec, but not the rock file, since it is a moving target.

3. Arbitrary: the dev versions should be uploaded using --force because imho adding rockspec revisions doesn't make sense, since the underlying code fetched from a repo is a moving target. Maybe @hishamhm has some thoughts on this.

The deploy workflow I was messing with here is ready to go, at least for my preferences. There are several choices to be made for how things will go that different maintainers may make differently, so it may need tuning to style. Examples:

• Bare semver tags like 1.2.3 or prefixed like v1.2.3 (my preference).
• Dev rockspec in root or elsewhere? Named dev or scm?
• Upload rockspecs on any file change, or only a tag matches the rockspec version?
• Upload rockspecs only on change, or any time a tag is pushed?
• Require all rockspecs pass tests before uploading any of them, or upload those that pass?
• Test build old rockspecs if touched?
• Upload from patch release branches or only the default branch?

Etc. All the machinery for these choices is worked out and most of them I've tried a few ways but settled on the option that makes the most sense to my project management style.

Also there are two places to setup those details: ⓐ they can be copied into each repo using them and adjusted there or ⓑ they could be copied into a common repo (perhaps even the .github) and referenced remotely from a workflow dispatcher. Already they are setup for use remotely, they just currently referencing the same repo. If anybody things it makes sense to stash them in a common repo I should expand the input/output options a bit to handle the choices above instead of leaving it to in-place tweaks.