Middle Mouse Bug Fix about dota2-thecore-config-engine

[Sembrani]

@dodekeract The .png should be set as binary so that git does not modify them, even through CRLF conversion. Looking at the current .gitattributes file, there is no *.png binary line? Perhaps this should be added.

*Edit: @dodekeract just re-read your comment, I believe you are correct, in that *.png binary should not have been removed. My apologies.

[FlorianWendelborn]

You can actually make a pull request without breaking them. Just use the Git shell (or bash) and enter the following commands:

git clone https://github.com/username/repository
cd repository
make your changes
git add filename-you-changed
git commit -m "commit message"
git push

Then create the pull-request from your fork.

[Aevyz]

The problem is my fork is all messed up, mostly my fault. Played around a bit too much. For some reason the Keyboard Images always are broken, like cannot open corrupted broken. Can't explain that, but whenever I pushed an update to my own fork, they wouldn't work. Also I'm using the Github app and not the shell (kinda too lazy to learn that right now).

[FlorianWendelborn]

If your fork is all messed up anyway, just delete it and re-fork.

[Aevyz]

Been there, done that. Computer still corrupts the PNG files for no apparent reason. I am planning to reinstall windows anyways during my summer break, so I'm gonna live with that problem until then.

Anyhow, I'm going to try it regardless, who knows, might work. Just thought I could post this here in the event that I can't fix it myself. Its better than leaving the bug in the wild without a fix.

Edit: Instantly have 9 corrupted images once I download the file. Guess I will try online editing...
Edit 2: As much as I dislike the online editor, I did it online

[FlorianWendelborn]

You can chose which files to add to a commit, even in the GUI. Just untick them next time.

[Aevyz]

Seems to work, thanks for the help. Now just to fix the PNG's, its messing with my OCD...

[FlorianWendelborn]

@AetherV Does this look similar to your issue? http://stackoverflow.com/questions/19411981/images-corrupt-after-git-push

If yes, then I guess it's the recent CRLF change someone@Sembrani pushed to this repo. I think it's working fine for me since I'm on Unix but you're on Windows.

[FlorianWendelborn]

@Sembrani I think you should revert removing that .png binary thing from .gitattributes, I assume this is causing problems here.

[Aevyz]

Ehm @dodekeract, what does that exactly mean. I've tried reading through that 15 times and its still blowing way over my head. I copied and pasted the .gitattributes text and it seems to work. Don't know why, don't know how, just that it seems to somehow work again. Guess I got some reading to do about the gitattributes file.

@Sembrani, I am free to do some testing if you can give me instructions.

[FlorianWendelborn]

@AetherV as far as I understand, Git thinks your .png files should be treated like text, aka - when you push the file, all 0x0A (Line feed) bytes get converted to 0x0D (Carriage return) + 0x0A (Line feed). This was setup because Windows is weird and needs CRLF to mark line endings, while most other OS just use Line Feed.

Converting either from CRLF to LF or from LF to CRLF (which this repository does afaik) will break binary files because 0x0A and 0x0D + 0x0A are no special characters in binary files, they are only meaningful in text files, which means the resulting files are complete nonsense.

If you're wondering why these bytes have these weird names, carriage return is related to typewriters, which actually had to return the paper to the start so they could write in the beginning of the line. 😆 Line feed means that the paper should shift a line down. Quite absurd if you think about it that we still use these terms and that Windows still "works like it would have to move the paper back to the beginning".

[Aevyz]

Good to know. Never heard of that problem, but it seems to kinda make sense to me. Thanks for the explanation 👍