lure / autoturnin Goto Github PK
View Code? Open in Web Editor NEWWow addon.
Wow addon.
I'd like to be able to run past Sayge and quickly select the dialog choices that give me +% damage. I think most players would prefer damage, and obviously if it's optional then those players/classes could have it switched off so they can make a manual choice.
Would that be possible to add?
Hi.
I noticed a small "quest objectives text misalignement" on the Quest window when both ElVUI 12.24 and AutoTurnIn 9.0.2 are activated.
Here is the default Blizzard Quest Window, with all addons disabled (as you can see, there's no problem):
Note that this default Quest Window looks the same when only AutoTurnIn 9.0.2 is enabled (all quests objectives look fine, the quest window looks the same as the above screenshot).
Here is the Quest Window when only ElvUI 12.24 is enabled (no misalignement, quests objectives look fine):
But when both ElvUI 12.24 and AutoTurnIn 9.0.2 are activated, here is how the Quest Window looks like:
World of Warcraft Shawdowlands version 9.0.5.38134
French locale (it may also happen with other languages, I don't know)
Windows 10 64bits, nvidia GTX 1070 (drivers: 465.89)
on Version 10.0.7, whenever I gain a level, I have to reload the UI due to an error with this addon. Failing to do so will make keyboard interactions ignored by the system, through a LUA error.
Every time i try to get the leatherworking quest from Rinling, it won't let me b/c it automatically gets "He Shoots, He Scores" and every time I click on him afterwards, it immediately closes the window. I have to disable autoturnin and reloadui, do the quest, then enable and reloadui every time.
What version number you are using?
10.0.1
What game client are you playing? Retail, Burning Crusade, Classic / Live, PTR, Beta
Retail 10.0.0.46313
What language is the game client set to?
German
Describe the bug
A clear and concise description of what the bug is.
On log in an lua error occurs (see below in "Additional context"). It looks like that AutoTurnIn takes the library from the first folder it founds inside the "AddOns" folder. Is AutoTurnIn using an old version of Ace3?
To Reproduce
Steps to reproduce the behaviour, if possible:
Log in to game with AutoTurnIn and ArkInventory active
It is also reproduceable if you install "Ace3" as dedicated addon.
Additional context
Add any other context about the problem here.
Message: Interface/AddOns/AutoTurnIn/AutoTurnIn.lua:94: attempt to call method 'LibDataStructure' (a nil value)
Time: Thu Oct 27 14:32:37 2022
Count: 1
Stack: Interface/AddOns/AutoTurnIn/AutoTurnIn.lua:94: attempt to call method 'LibDataStructure' (a nil value)
[string "@Interface/AddOns/AutoTurnIn/AutoTurnIn.lua"]:94: in function <Interface/AddOns/AutoTurnIn/AutoTurnIn.lua:63>
[string "=[C]"]: ?
[string "@Interface/AddOns/ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua"]:66: in function <...rkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua"]:626: in function <...rkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua:611>
[string "=[C]"]: in function `LoadAddOn'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11090: in function `LoadAddOn'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11106: in function `BlizzardAPIHook'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:2886: in function <Interface/AddOns/ArkInventory/Core/ArkInventory.lua:2855>
[string "=[C]"]: ?
[string "@Interface/AddOns/ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua"]:66: in function <...rkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua"]:626: in function <...rkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua:611>
Locals: <none>
** Alternative lua error with "Ace3" installed **
Message: Interface/AddOns/AutoTurnIn/AutoTurnIn.lua:94: attempt to call method 'LibDataStructure' (a nil value)
Time: Thu Oct 27 14:46:17 2022
Count: 1
Stack: Interface/AddOns/AutoTurnIn/AutoTurnIn.lua:94: attempt to call method 'LibDataStructure' (a nil value)
[string "@Interface/AddOns/AutoTurnIn/AutoTurnIn.lua"]:94: in function <Interface/AddOns/AutoTurnIn/AutoTurnIn.lua:63>
[string "=[C]"]: ?
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:66: in function <Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:626: in function <Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua:611>
[string "=[C]"]: in function `LoadAddOn'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11090: in function `LoadAddOn'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11106: in function `BlizzardAPIHook'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:2886: in function <Interface/AddOns/ArkInventory/Core/ArkInventory.lua:2855>
[string "=[C]"]: ?
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:66: in function <Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:626: in function <Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua:611>
Locals: <none>
https://github.com/lure/AutoTurnIn/blob/master/AutoTurnIn.lua#L94
Hey,
i've got something weird, when the ACE3 is used from another addon
AutoTurnIn (ATI) Version 10.3.1
22x AutoTurnIn/AutoTurnIn.lua:420: hooksecurefunc(): ObjectiveTracker_Update is not a function
[string "=[C]"]: in function `hooksecurefunc'
[string "@AutoTurnIn/AutoTurnIn.lua"]:420: in function <AutoTurnIn/AutoTurnIn.lua:404>
[string "=[C]"]: ?
[string "@ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0-13.lua"]:66: in function <...rkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua:61>
[string "@ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0-13.lua"]:494: in function `InitializeAddon'
[string "@ArkInventory/Externals/Ace3/AceAddon/AceAddon-3.0-13.lua"]:619: in function <...rkInventory/Externals/Ace3/AceAddon/AceAddon-3.0.lua:611>
If i rename "AutoTurnIn" to "1AutoTurnIn" to use the delivered ACE3, this issue does not popup.
I've checked the delivered ACE3's, and they are both on 3.0-13 and identical. I also copied the ATI Version to Ark and the issue persist. So its maybe just a "path" thing, that the reference does not match
4x AutoTurnIn\QuestLevel.lua:61: attempt to index local 'questInfo' (a nil value)
[string "@AutoTurnIn\QuestLevel.lua"]:61: in function <AutoTurnIn\QuestLevel.lua:42>
[string "=[C]:"]: in function 'ObjectiveTracker_Update'
[string "@Blizzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua"]:930: in function <...zzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua:833>
Locals:
self = nil
tracker = ObjectiveTrackerFrame {
0 = <userdata>
contentsHeight = 0
blockTemplate = "ObjectiveTrackerBlockTemplate"
fromModuleOffsetY = -10
HeaderMenu = <unnamed> {
}
fromHeaderOffsetY = -10
updateReasonEvents = 0
lineSpacing = 2
freeLines = <table> {
}
freeTimerBars = <table> {
}
lineTemplate = "ObjectiveTrackerLineTemplate"
freeProgressBars = <table> {
}
usedTimerBars = <table> {
}
isUpdating = false
hasSkippedBlocks = false
usedBlocks = <table> {
}
oldContentsHeight = 0
lastMapID = 590
MODULES = <table> {
}
blockType = "Frame"
blockOffset = <table> {
}
BlockDropDown = ObjectiveTrackerBlockDropDown {
}
lineWidth = 0
isUpdateDirty = false
initialized = true
contentsAnimHeight = 0
friendlyName = "DEFAULT_OBJECTIVE_TRACKER_MODULE"
watchMoneyReasons = 0
poolCollection = <table> {
}
BlocksFrame = ObjectiveTrackerBlocksFrame {
}
MODULES_UI_ORDER = <table> {
}
usedProgressBars = <table> {
}
updateReasonModule = 0
}
(for index) = 5
(for limit) = 7
(for step) = 1
i = 5
(for generator) = <function> defined =[C]:-1
(for state) = <table> {
ObjectiveTrackerBlockTemplate = <table> {
}
}
(for control) = "ObjectiveTrackerBlockTemplate"
blockTemplate = "ObjectiveTrackerBlockTemplate"
blockTable = <table> {
61874 = <unnamed> {
}
}
(for generator) = <function> defined =[C]:-1
(for state) = <table> {
61874 = <unnamed> {
}
}
(for control) = 61874
id = 61874
block = <unnamed> {
0 = <userdata>
lines = <table> {
}
id = 61874
module = <table> {
}
HeaderButton = ObjectiveTrackerBlocksFrameHeader {
}
blockTemplate = "ObjectiveTrackerBlockTemplate"
HeaderText = <unnamed> {
}
nextBlock = <unnamed> {
}
height = 12.034206
used = true
}
questLogIndex = 4
questInfo = nil
(*temporary) = nil
(*temporary) = 4
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'questInfo' (a nil value)"
Since 7.2 IsQuestIgnored() seems to always return nil and cause an error.
Removing the call to this function from the elseif condition in the function AutoTurnIn:QUEST_DETAIL removes the error aswell. I did not check if this breaks anything else.
On the off-chance that this matters (since it's not really a bug but a different behavior regarding an add-on) I'd like to share that while using Immersion the quests aren't automatically accepted.
I mean... They are (sometimes) but first you have to manually accept one (sometimes multiple).
This wasn't the case with the previous version. I was able to automatically accept all quests without any issues while using Immersion
I should also add that this behavior is not exclusive to AutoTurnIn. Similar add-ons face the same issue.
ISSUE FIXED BY THE LATEST RELEASE - POSTED WITHOUT KNOWING AN UPDATE WAS AVAILABLE - SORRY
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.