lurodrigo / firestore-clj Goto Github PK

I'll formalize the emulator code in this issue: codestiff#1

Until then let me give you a quick run down.
The code here: #4
was designed to avoid needing the java process running your clojure to have the env variable, FIRESTORE_EMULATOR_HOST

Background:
Most of what I did is analyze the google cloud firestore client. Located here: https://github.com/googleapis/java-firestore

We can see where I found the idea for FakeCredentials here: https://github.com/googleapis/java-firestore/blob/813e246f8ec5d25e8101480e3e21270160fdf2cc/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreOptions.java#L264

Observations:

• It looks like the source does not want you to connect to the emulator outside of setting the
  env variable.
  • See: https://github.com/googleapis/java-firestore/blob/813e246f8ec5d25e8101480e3e21270160fdf2cc/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreOptions.java#L230
  • And here: https://github.com/googleapis/java-firestore/blob/813e246f8ec5d25e8101480e3e21270160fdf2cc/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreOptions.java#L59
• I specifically want to be able to connect to the emulator without setting the environment variable. It's possible (but not verified by me) that some of the configuration steps can be removed if that use case is replaced w/ requiring users to set the environment variable, FIRESTORE_EMULATOR_HOST

There seems to be a typo in the name of the function sort-by - it should be order-by in the README file. I checked the source code and tested as well.

Hi,

Suddenly I started getting the following error in the case of create (add!) and update (merge!) calls:

Execution error (NoSuchMethodError) at com.google.firestore.v1.Document/writeTo (Document.java:480). com.google.protobuf.GeneratedMessageV3.serializeStringMapTo(Lcom/google/protobuf/CodedOutputStream;Lcom/google/protobuf/MapField;Lcom/google/protobuf/MapEntry;I)V

A quick search indicates that there are potentially version issues wrt gRPC/Protobuff. But it is surprising because, the same operations were fine a day ago.

I am wondering if you also have come across the same issue? I tried some deps exclusions, but it hasn't worked yet.

This is a wonderful contribution. I want to use it in the Firestore version of my Datastore library for AppEngine. In that library I'm using the AppEngine test doubles for Datastore but there is no such thing for Firestore. Only the emulator. How do you write good tests with this thing?

It looks like one of the "necessary" (for some circumstances) steps before using firestore-clj is to set managed-dependencies. I'm not familiar with what is happening here but suffice it to say, I've been needing to do things like: https://github.com/codestiff/connective/blob/0.1.7/modules/connective-firestore/project.clj#L8

In order to work w/ firestore-clj. I think a more complete picture of what is causing compilation issues when not using managed-dependencies is worthwhile.

For example,

Caused by: java.lang.NoClassDefFoundError: io/grpc/ManagedChannel
        at java.base/java.lang.Class.getDeclaredMethods0(Native Method)
        at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3119)
        at java.base/java.lang.Class.privateGetPublicMethods(Class.java:3144)
        at java.base/java.lang.Class.getMethods(Class.java:1863)
        at clojure.lang.Reflector.getMethods(Reflector.java:498)
        at clojure.lang.Compiler$HostExpr$Parser.parse(Compiler.java:994)
        at clojure.lang.Compiler.analyzeSeq(Compiler.java:7107)
        ... 196 more
Caused by: java.lang.ClassNotFoundException: io.grpc.ManagedChannel
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:582)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:190)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:499)
        ... 203 more
Subprocess failed
REPL server launch timed out.