lutangar / cities.json Goto Github PK

Even the city suggested in the readme is missing.. (Lyon)

When I execute convert.js I get this error:

 jakob  F:  Programming projects  Weather-App  src  lib  city-data  master  node ./convert.js             
node:events:492
      throw er; // Unhandled 'error' event
      ^

Error: ENOENT: no such file or directory, open 'F:\Programming projects\Weather-App\src\lib\city-data\cities1000.txt'
Emitted 'error' event on Interface instance at:
    at ReadStream.onerror (node:internal/readline/interface:239:10)
    at ReadStream.emit (node:events:514:28)
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'open',
  path: 'F:\\Programming projects\\Weather-App\\src\\lib\\city-data\\cities1000.txt'
}

cities.json inclues a lot of string values that have unescaped forward slashes ('/').

According to https://www.json.org/json-en.html , these are the characters than must be escaped; and forward slash ('/') is among them.

Chars to be escaped:
'"'
''
'/'
'b'
'f'
'n'
'r'
't'
'u' hex hex hex hex

A quick search and replace solves the issue but not doing it cause unexpected results.

Currently there is no way to differentiate cities with the same name if they belong to the same country besides the lat-lon. Perhaps, since this is in json format, add the state/region to cities with similar names? This way there is no need to add the state/region to all cities.

First of all I want to give you a BIG thank you for this amazing work.

I was wondering, though, If it would be possible to publish this package to npm? So we can use it on server-side applications. I don't know if that would be the best strategy but I these main strenghts:

• One could easily update one's service by upgrading the package version
• Server-side we would not have to contact any remote database thus reducing the latency issues

I think about the npm package countries-list, that is hosted in Github on https://github.com/annexare/Countries

I don't know if there would be any performance issues given the size of the generated file, but I would like to open the discussion to know what you think about.

Where did you get this data?
Unfortunately it's missing cities, like mine: Guaratinguetá (state: São Paulo, country: BR)