lvivski / davy Goto Github PK

Hi,

When calling Promise.all with an array, it will try to resolve all promises using Promise.each, calling it on the array and a resolve function ( https://github.com/lvivski/davy/blob/master/src/extra.js#L68 ), assigning the result to a resolver variable.

Problem is this resolver variable is used inside the resolve function ( https://github.com/lvivski/davy/blob/master/src/extra.js#L89 ), but it will still be undefined since the call to Promise.each is completed yet.

Isn't there something wrong here?

I don't really know why, but after installing davy using Bower and targeting the 0.3.0 version, I have the following code at line 157:

  Promise.reject = function(err) {
    var resolver = new Resolver();
    resolver.reject(err);
    return resolve.promise;
  };

Which does not match the source code for the 0.3.0 version, using Promise.defer() rather than new Resolver(). I don't why but it's problematic since it does not work (because it creates a Resolver with no this.promise and when trying to reject it, it fails)...

Cheers

DOM promises are in Chrome behind flag today.

But they are in. I propose to remove global.Promise = ... as this will confuse libs that try to detect native promises.

foo = new Davy
bar = new Davy

Is it possible to make a deferred that exectures when booth foo and bar is fulfilled with Davy?

thx!