The algorithms from lxylxy123456

Graph does not support std::pair as vertex type

To reproduce, try to compile:

#include "Graph.hpp"
int main() {
	algorithms::GraphAdjList<std::pair<int, int>> a(1);
	return 0;
}

valgrind job in CI is re-building the targets instead of using downloaded executables

See ci-test branch

Test more on IntervalTree

There may be a bug in the implementation of IntervalTree. Under some random values src/IntervalTreeTest fails.

Fix valgrind failures

The following tests have problems when running with valgrind

Replace size_t with std::size_t

60f60a5 is a temporary workaround to make sure size_t will be defined. However, we should try to remove size_t in source code and use std::size_t instead.

Problem with RelabelToFrontTest

Valgrind fails: https://github.com/lxylxy123456/algorithms/pull/44/checks?check_run_id=1583735074 ==8588==

Support other compilers (e.g. Clang / LLVM)

Refine includes

Update include_check.py or use some linter to make sure no redundant includes are in the programs.

Problem with FordFulkersonTest

https://github.com/lxylxy123456/algorithms/runs/1574645545?check_suite_focus=true

valgrind --error-exitcode=1 --tool=memcheck --leak-check=full --errors-for-leak-kinds=definite ./bin/FordFulkersonTest valgrind > /dev/null
==8765== Memcheck, a memory error detector
==8765== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==8765== Using Valgrind-3.13.0 and LibVEX; rerun with -h for copyright info
==8765== Command: ./bin/FordFulkersonTest valgrind
==8765== 
==8765== Invalid write of size 8
==8765==    at 0x10F063: algorithms::Queue<unsigned long>::Enqueue(unsigned long) (Queue.hpp:31)
==8765==    by 0x10CE99: void algorithms::BFS<algorithms::GraphAdjList<unsigned long>, unsigned long>(algorithms::GraphAdjList<unsigned long>&, unsigned long, std::unordered_map<unsigned long, algorithms::BFSInfo<unsigned long>, std::hash<unsigned long>, std::equal_to<unsigned long>, std::allocator<std::pair<unsigned long const, algorithms::BFSInfo<unsigned long> > > >&) (BFS.hpp:51)
==8765==    by 0x10B64E: void algorithms::FordFulkerson<algorithms::GraphAdjList<unsigned long>, unsigned long, int>(algorithms::GraphAdjList<unsigned long>&, std::unordered_map<algorithms::Edge<unsigned long>, int, algorithms::EdgeHash<unsigned long>, std::equal_to<algorithms::Edge<unsigned long> >, std::allocator<std::pair<algorithms::Edge<unsigned long> const, int> > >&, unsigned long, unsigned long, std::unordered_map<algorithms::Edge<unsigned long>, int, algorithms::EdgeHash<unsigned long>, std::equal_to<algorithms::Edge<unsigned long> >, std::allocator<std::pair<algorithms::Edge<unsigned long> const, int> > >&) (FordFulkerson.hpp:52)
==8765==    by 0x109AFA: test(unsigned long, unsigned long) (FordFulkersonTest.cpp:39)
==8765==    by 0x10A1E0: main (FordFulkersonTest.cpp:73)
==8765==  Address 0x5e75200 is 0 bytes after a block of size 0 alloc'd
==8765==    at 0x4C3289F: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==8765==    by 0x10EFEC: algorithms::Queue<unsigned long>::Queue(unsigned long) (Queue.hpp:29)
==8765==    by 0x10CE83: void algorithms::BFS<algorithms::GraphAdjList<unsigned long>, unsigned long>(algorithms::GraphAdjList<unsigned long>&, unsigned long, std::unordered_map<unsigned long, algorithms::BFSInfo<unsigned long>, std::hash<unsigned long>, std::equal_to<unsigned long>, std::allocator<std::pair<unsigned long const, algorithms::BFSInfo<unsigned long> > > >&) (BFS.hpp:50)
==8765==    by 0x10B64E: void algorithms::FordFulkerson<algorithms::GraphAdjList<unsigned long>, unsigned long, int>(algorithms::GraphAdjList<unsigned long>&, std::unordered_map<algorithms::Edge<unsigned long>, int, algorithms::EdgeHash<unsigned long>, std::equal_to<algorithms::Edge<unsigned long> >, std::allocator<std::pair<algorithms::Edge<unsigned long> const, int> > >&, unsigned long, unsigned long, std::unordered_map<algorithms::Edge<unsigned long>, int, algorithms::EdgeHash<unsigned long>, std::equal_to<algorithms::Edge<unsigned long> >, std::allocator<std::pair<algorithms::Edge<unsigned long> const, int> > >&) (FordFulkerson.hpp:52)
==8765==    by 0x109AFA: test(unsigned long, unsigned long) (FordFulkersonTest.cpp:39)
==8765==    by 0x10A1E0: main (FordFulkersonTest.cpp:73)
==8765== 
==8765== Invalid read of size 8
==8765==    at 0x10F1B0: algorithms::Queue<unsigned long>::Dequeue() (Queue.hpp:43)
==8765==    by 0x10CEBC: void algorithms::BFS<algorithms::GraphAdjList<unsigned long>, unsigned long>(algorithms::GraphAdjList<unsigned long>&, unsigned long, std::unordered_map<unsigned long, algorithms::BFSInfo<unsigned long>, std::hash<unsigned long>, std::equal_to<unsigned long>, std::allocator<std::pair<unsigned long const, algorithms::BFSInfo<unsigned long> > > >&) (BFS.hpp:53)
==8765==    by 0x10B64E: void algorithms::FordFulkerson<algorithms::GraphAdjList<unsigned long>, unsigned long, int>(algorithms::GraphAdjList<unsigned long>&, std::unordered_map<algorithms::Edge<unsigned long>, int, algorithms::EdgeHash<unsigned long>, std::equal_to<algorithms::Edge<unsigned long> >, std::allocator<std::pair<algorithms::Edge<unsigned long> const, int> > >&, unsigned long, unsigned long, std::unordered_map<algorithms::Edge<unsigned long>, int, algorithms::EdgeHash<unsigned long>, std::equal_to<algorithms::Edge<unsigned long> >, std::allocator<std::pair<algorithms::Edge<unsigned long> const, int> > >&) (FordFulkerson.hpp:52)
==8765==    by 0x109AFA: test(unsigned long, unsigned long) (FordFulkersonTest.cpp:39)
==8765==    by 0x10A1E0: main (FordFulkersonTest.cpp:73)
==8765==  Address 0x5e75200 is 0 bytes after a block of size 0 alloc'd
==8765==    at 0x4C3289F: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==8765==    by 0x10EFEC: algorithms::Queue<unsigned long>::Queue(unsigned long) (Queue.hpp:29)
==8765==    by 0x10CE83: void algorithms::BFS<algorithms::GraphAdjList<unsigned long>, unsigned long>(algorithms::GraphAdjList<unsigned long>&, unsigned long, std::unordered_map<unsigned long, algorithms::BFSInfo<unsigned long>, std::hash<unsigned long>, std::equal_to<unsigned long>, std::allocator<std::pair<unsigned long const, algorithms::BFSInfo<unsigned long> > > >&) (BFS.hpp:50)
==8765==    by 0x10B64E: void algorithms::FordFulkerson<algorithms::GraphAdjList<unsigned long>, unsigned long, int>(algorithms::GraphAdjList<unsigned long>&, std::unordered_map<algorithms::Edge<unsigned long>, int, algorithms::EdgeHash<unsigned long>, std::equal_to<algorithms::Edge<unsigned long> >, std::allocator<std::pair<algorithms::Edge<unsigned long> const, int> > >&, unsigned long, unsigned long, std::unordered_map<algorithms::Edge<unsigned long>, int, algorithms::EdgeHash<unsigned long>, std::equal_to<algorithms::Edge<unsigned long> >, std::allocator<std::pair<algorithms::Edge<unsigned long> const, int> > >&) (FordFulkerson.hpp:52)
==8765==    by 0x109AFA: test(unsigned long, unsigned long) (FordFulkersonTest.cpp:39)
==8765==    by 0x10A1E0: main (FordFulkersonTest.cpp:73)
==8765== 
==8765== 
==8765== HEAP SUMMARY:
==8765==     in use at exit: 0 bytes in 0 blocks
==8765==   total heap usage: 74,567 allocs, 74,567 frees, 4,063,104 bytes allocated
==8765== 
==8765== All heap blocks were freed -- no leaks are possible
==8765== 
==8765== For counts of detected and suppressed errors, rerun with: -v
==8765== ERROR SUMMARY: 2 errors from 2 contexts (suppressed: 0 from 0)
make: *** [valgrind/FordFulkersonTest] Error 1

Support other C++ standards

Currently this project uses C++ 11. However we can try to support other stds.

Research on RelabelToFrontTest

See whether RelabelToFrontTest can give solution with cycle flow

Rewrite printtree.hpp

There are some inherent limitations in printtree.hpp, also that file is not original work. It would be better to re-implement this file.

Change the way random numbers are generated

We should not use a random_device as the input to uniform_int_distribution. Instead, we should use a generator. This also allows us to print the seed and thus get deterministic result.
See https://en.cppreference.com/w/cpp/numeric/random/uniform_int_distribution as an example.

lxylxy123456 / algorithms Goto Github PK

algorithms's People

Contributors

Stargazers

Watchers

algorithms's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs