lyrillind / dark-bint-syntax

A syntax for Atom

dark-bint-syntax theme

A dark theme based on seti.

dark-bint-syntax's Issues

Deprecated selector in `dark-bint-syntax\index.less`

In dark-bint-syntax\index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• atom-text-editor, atom-text-editor[mini], atom-text-editor[mini]::shadow, :host => atom-text-editor, atom-text-editor[mini], atom-text-editor[mini].editor,atom-text-editor

• atom-text-editor, :host => atom-text-editor,atom-text-editor

• atom-text-editor .line.cursor-line, :host .line.cursor-line => atom-text-editor .line.cursor-line,atom-text-editor .line.cursor-line

• atom-text-editor .invisible, :host .invisible => atom-text-editor .invisible,atom-text-editor .invisible

• atom-text-editor .cursor, :host .cursor => atom-text-editor .cursor,atom-text-editor .cursor

• atom-text-editor .selection .region, :host .selection .region => atom-text-editor .selection .region,atom-text-editor .selection .region

• atom-text-editor .bracket-matcher .region, :host .bracket-matcher .region => atom-text-editor .bracket-matcher .region,atom-text-editor .bracket-matcher .region

• atom-text-editor .invisible-character, :host .invisible-character => atom-text-editor .invisible-character,atom-text-editor .invisible-character

• atom-text-editor .indent-guide, :host .indent-guide => atom-text-editor .indent-guide,atom-text-editor .indent-guide

• atom-text-editor .wrap-guide, :host .wrap-guide => atom-text-editor .wrap-guide,atom-text-editor .wrap-guide

• atom-text-editor .gutter .line-number, :host .gutter .line-number => atom-text-editor .gutter .line-number,atom-text-editor .gutter .line-number

• atom-text-editor .gutter .line-number.cursor-line, :host .gutter .line-number.cursor-line => atom-text-editor .gutter .line-number.cursor-line,atom-text-editor .gutter .line-number.cursor-line

• atom-text-editor .gutter .line-number .icon-right, :host .gutter .line-number .icon-right => atom-text-editor .gutter .line-number .icon-right,atom-text-editor .gutter .line-number .icon-right

• atom-text-editor .gutter:not(.git-diff-icon) .line-number.git-line-removed.git-line-removed::before, :host .gutter:not(.git-diff-icon) .line-number.git-line-removed.git-line-removed::before => atom-text-editor .gutter:not(.git-diff-icon) .line-number.git-line-removed.git-line-removed::before,atom-text-editor .gutter:not(.git-diff-icon) .line-number.git-line-removed.git-line-removed::before

• atom-text-editor .gutter:not(.git-diff-icon) .line-number.git-line-removed::after, :host .gutter:not(.git-diff-icon) .line-number.git-line-removed::after => atom-text-editor .gutter:not(.git-diff-icon) .line-number.git-line-removed::after,atom-text-editor .gutter:not(.git-diff-icon) .line-number.git-line-removed::after

• atom-text-editor .gutter .line-number.folded, :host .gutter .line-number.folded, atom-text-editor .gutter .line-number:after, :host .gutter .line-number:after, atom-text-editor .fold-marker:after, :host .fold-marker:after => atom-text-editor .gutter .line-number.folded,atom-text-editor .gutter .line-number.folded, atom-text-editor .gutter .line-number:after,atom-text-editor .gutter .line-number:after, atom-text-editor .fold-marker:after,atom-text-editor .fold-marker:after

• .comment => .syntax--comment

• `.e

Failed to activate the dark-bint-syntax theme

Hi,

I've noticed something strange about this theme, that I can't seem to find a cause for myself. Here's the full error report:

---

[Enter steps to reproduce below:]

1. Start Atom with dark-bint-syntax set as the syntax theme

Atom Version: 1.8.0
System: "Arch Linux"
Thrown From: dark-bint-syntax package, v0.8.7

Stack Trace

Failed to activate the dark-bint-syntax theme

At 'editor.less' wasn't found in /home/fusion809/.atom/packages/dark-bint-syntax/index.less:4:0

LessError: 'editor.less' wasn't found
  at /home/fusion809/.atom/packages/dark-bint-syntax/index.less:4:0

Commands

Config

{
  "core": {
    "disabledPackages": [
      "about",
      "language-gfm",
      "language-shellscript"
    ],
    "projectHome": "/home/fusion809/GitHub/mine",
    "themes": [
      "fusion-ui",
      "dark-bint-syntax"
    ]
  }
}

Installed Packages

# User
autocomplete-html-entities, v0.1.0
autocomplete-json, v5.0.2
autocomplete-modules, v1.5.1
autocomplete-php, v0.3.7
autocomplete-python, v1.7.5
autocomplete-ruby, v0.1.0
autocomplete-sass, v0.1.0
file-icons, v1.7.13
fusion-ui, v0.10.6
go-config, v1.1.4
go-get, v1.0.3
linter-coffeescript, v1.0.0
linter-jslint, v10.2.0
minimap, v4.24.3
package-sync, v1.1.0
pigments, v0.29.1
platformio-ide-terminal, v2.0.10

# Dev
No dev packages

---

Line Numbers Overlapping

Every 7th line number ends up underneath every 6th line number. Playing around right now with the theme's .less files to see if I can fix the issue.

To be sure it wasn't the Syntax theme, I did try switching the UI theme. The issue was still there though. Also, I listed the current version of Atom I'm using, but I only just updated to that version after installing this theme. Previous version was 1.2.1.

Atom version: 1.2.2
Theme version: 0.5.0
OS: Windows 10

Also, after looking at your repo, I see changes you already made to fix this (b02b563). I can confirm they work.

Line number alignment in gutter

The font used in the line numbers (PT Mono) throws off alignment. When I disable it in the dev tools, the alignment is fixed.

At first I thought the spaces themselves weren't monospace (as if they were overlooked by the font artist). But now I'm not sure why they're behaving this way...

An opinion

Your syntax theme, gosh! Been looking all over for a theme to fall in love with, and then I found yours!

When typing in my .css-file
I think that the ".selected" and ":hover" should have some other color than the standard.
For example:
nav a.selected, nav a:hover {
color: #32673f;
}

Hope you can consider this, so I can continue to brag about the color scheme. :happy