m-zubairahmed / atomurl Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 0.0 24.41 MB

A URL shortner package

Home Page: https://atomurlapp.herokuapp.com/

License: MIT License

Go 32.26% HTML 11.21% JavaScript 50.34% CSS 6.19%

golang reactjs url-shortener

atomurl's Introduction

atomurl's People

Contributors

Stargazers

Watchers

atomurl's Issues

Server side error reporting on wrong field

Describe the bug
The server sided bugs are being reported on wrong frontend field.

To Reproduce
Steps to reproduce the behavior:

Enter wrong or invalid distination url

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
All

Smartphone (please complete the following information):
All

Additional context

Add not found page

use cors package

Use cors package https://github.com/gin-contrib/cors instead of writing your own

Add server side validation

url.Parse() to validate input urls. Also it should never allow destination url to be that of atomurl

Remove double concat

Remove print.sprint as + is already concatening in

atomURL/main.go

Line 188 in da5bd77

 databaseURL := fmt.Sprint(databaseHost + "://" + databaseUserName + ":" + databaseUserPassword + "@" + databaseAddress + "/" + databaseName) 

Add server validatoin for shorturl

allowed small letters and hyphen
extends issue #6

Simplify getting env

Instead of this

atomURL/main.go

Lines 163 to 186 in da5bd77

 databaseHost := os.Getenv("DB_HOST") 

 if os.Getenv("DB_HOST") == "" { 

 log.Fatal("No Database host provided eg. <mongodb>://") 

 } 

 databaseUserName := os.Getenv("DB_USER") 

 if os.Getenv("DB_USER") == "" { 

 log.Fatal("No Database user name provided") 

 } 

 databaseUserPassword := os.Getenv("DB_PASSWORD") 

 if os.Getenv("DB_PASSWORD") == "" { 

 log.Fatal("No Database user's password provided") 

 } 

 databaseAddress := os.Getenv("DB_URL") 

 if os.Getenv("DB_URL") == "" { 

 log.Fatal("No Database URL provided") 

 } 

 databaseName := os.Getenv("DB_NAME") 

 if os.Getenv("DB_NAME") == "" { 

 log.Fatal("NO Database name provided") 

 }

Do this

Logo

use default gin

Replace with gin.Default() for other defaults in the router, and remove explicitly adding logging etc.

Dont load whole of fontawesome

Is your feature request related to a problem? Please describe.
Blog of request for all of fontawesome

Describe the solution you'd like
Store locally icons required

Describe alternatives you've considered
none

Additional context
none

	databaseHost := os.Getenv("DB_HOST")
	if os.Getenv("DB_HOST") == "" {
	log.Fatal("No Database host provided eg. <mongodb>://")
	}

	databaseUserName := os.Getenv("DB_USER")
	if os.Getenv("DB_USER") == "" {
	log.Fatal("No Database user name provided")
	}

	databaseUserPassword := os.Getenv("DB_PASSWORD")
	if os.Getenv("DB_PASSWORD") == "" {
	log.Fatal("No Database user's password provided")
	}

	databaseAddress := os.Getenv("DB_URL")
	if os.Getenv("DB_URL") == "" {
	log.Fatal("No Database URL provided")
	}

	databaseName := os.Getenv("DB_NAME")
	if os.Getenv("DB_NAME") == "" {
	log.Fatal("NO Database name provided")
	}

m-zubairahmed / atomurl Goto Github PK

atomurl's Introduction

atomurl's People

Contributors

Stargazers

Watchers

atomurl's Issues

Additional context

Recommend Projects

Recommend Topics

Recommend Org

Jobs