m0skit0 / maps-wrapper Goto Github PK

CommonMap.addPolyline supports nullable
OnMapReadyCallback supports nullable
OnMarkerClickListener supports nullable

com.google.android.gms.maps.model.Tile
com.google.android.gms.maps.model.TileOverlayOptions
com.google.android.gms.maps.model.TileProvider
com.google.android.gms.maps.model.VisibleRegion
com.google.android.gms.maps.model.UrlTileProvider

I consider not to use type as attribute, maybe another libraries use same attribute that will make issues.
better to rename it to wrappedMapType as example ...

Method setMapStyle is missing from CommonMap! I would like to have it, so we can set a dark theme!

Respect subpackages from original API, e.g. models, etc...

Currently models are instantiated when the wrapper is instantiated. A better approach would be to defer this instantiation until the actual API is going to be called.

StreetViewPanorama, StreetViewSource, StreetViewPanoramaOptions, StreetViewPanoramaView, SupportStreetViewPanoramaFragment (currently not supported by Huawei Maps)

GroundOverlayOptions missing anchor() method
GroundOverlay missing transparency, setImage, isClickable

Hi
Is it possible to get the user location with this lib ?

CommonMap missing focusedBuilding, MAP_TYPE_*

• CommonMap.OnMapLoadedCallback
• CommonMap.OnMyLocationButtonClickListener
• CommonMap#setOnMapLoadedCallback
• CommonMap#setOnMyLocationButtonClickListener
• LatLngBounds#northeast
• LatLngBounds#southwest
• Projection#toScreenLocation
• Projection#getVisibleRegion
• Marker#remove
• CameraPosition#bearing
• GroundOverlay#zIndex
• GroundOverlay#remove
• GroundOverlay#setVisible
• GroundOverlay#isVisible
• CameraUpdateFactory#zoomBy
• TileOverlay#setZIndex
• LatLngBounds#contains
• LatLngBounds#getCenter
• CommonMap#getMyLocation
• MapView#onStart
• MapView#onResume
• MapView#onPause
• MapView#onStop
• MapView#onDestroy
• MapView#onLowMemory
• MapView#onSavedInstanceState
• BitmapDescriptionFactory.defaultMarker() (non-arg)

Wrong package for BitmapDescriptorFactory

Hey,

can you add a license for your library like Apache 2.0? So we can fork, modify and use it legally?

Thanks.

Could you add the remove function to marker?

fun remove(){
  google?.remove()
  huawei?.remove()
}

CommonMap missing OnMyLocationButtonClickListener, OnMyLocationClickListener, setOnMyLocationButtonClickListener, setOnMyLocationClickListener