GithubHelp home page GithubHelp logo

Comments (4)

maartenba avatar maartenba commented on July 30, 2024

Great idea, what would you propose code-wise? I was thinking of a configuration provider in which you can plug web.config but also other config systems like your own database or something

from googleanalyticstracker.

Korayem avatar Korayem commented on July 30, 2024

I was thinking of adding a new constructor with no parameters that defaults to getting values from web.config. Specifically in :

  • GoogleAnalyticsTracker/ActionTrackingAttribute.cs
  • GoogleAnalyticsTracker/Tracker.cs

And in web.config it would be like:

  <appSettings>
    <add key="GoogleAnalytics" value="UA-9999999-9" />
    <add key="Domain" value="localhost.com" />
  </appSettings>

I wasn't thinking of complicating it with a configuration provider because most projects I've seen don't store such data in database. A simple ConfigurationManager.AppSettings["GoogleAnalytics"] would suffice until someone else (like me) asks for getting values from database :)

from googleanalyticstracker.

maartenba avatar maartenba commented on July 30, 2024

This has been added. Add the GoogleAnalyticsTracker.TrackingAccount and GoogleAnalyticsTracker.TrackingDomain keys to your appsettings.

from googleanalyticstracker.

Korayem avatar Korayem commented on July 30, 2024

Sweeeet!!

from googleanalyticstracker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.