GithubHelp home page GithubHelp logo

Comments (10)

ckadner avatar ckadner commented on June 6, 2024

I will need to take a look at this. In a broader sense, the API should validate the uploaded template and reject malformed YAML or invalid metadata formats.

from mlx.

ckadner avatar ckadner commented on June 6, 2024

Thanks to @drewbutlerbb4 for fixing part of the issue in PR #104

I still need to add some code in the MLX API to validate the YAML structure and return a meaningful error message if something is not right.

Currently we show an error like this, if the YAML is missing required elements:

Upload Error: Please Retry - "TypeError: 'NoneType' object is not iterable"

from mlx.

ckadner avatar ckadner commented on June 6, 2024

@romeokienzler -- the component you attached here does not cause any errors for me (anymore?). Can you try again on the latest code base?

from mlx.

drewbutlerbb4 avatar drewbutlerbb4 commented on June 6, 2024

@ckadner #104 fixed the error that @romeokienzler was seeing for the UI.

When uploading a (potentially defunct) component.yaml breaks UI.

I'm not sure if this component.yaml is invalid? If it is, it passes through the API instead of returning an error to the UI. I think that was @romeokienzler initial point.

from mlx.

ckadner avatar ckadner commented on June 6, 2024

I did not see any errors in the API when I tried it. I had manufactured an error by altering the "inputs" field, to catch/fix the Upload Error: 'NoneType' object is not iterable e4145b2

from mlx.

ckadner avatar ckadner commented on June 6, 2024

@ckadner #104 fixed the error that @romeokienzler was seeing for the UI.

When uploading a (potentially defunct) component.yaml breaks UI.

@drewbutlerbb4 -- what error did you see there then?

from mlx.

romeokienzler avatar romeokienzler commented on June 6, 2024
out.mp4

I get the same behavior (see above) on version/commit e4145b2

from mlx.

drewbutlerbb4 avatar drewbutlerbb4 commented on June 6, 2024

@romeokienzler what is your setup here? Docker-compose? I can't reproduce this using the nightly build image with docker-compose setup

from mlx.

ckadner avatar ckadner commented on June 6, 2024

I get the same behavior (see above) on version/commit e4145b2

@romeokienzler -- in your video, I see the MLX UI still says:

"Enter a name and upload a .tgz or .tar.gz file to create a new component".

That was before Andrew's fix in PR #104 (bb69575). Now it should read:

"Enter a name and upload a .tgz, .tar.gz, .yaml or .yml file to register a new component".

Could you do a docker compose pull to get the latest nightly images to be pulled into your Docker Compose stack?

from mlx.

romeokienzler avatar romeokienzler commented on June 6, 2024

@ckadner @drewbutlerbb4 sorry for the hassle - I did a "git pull" but no "docker-compose pull" - everything is working fine now, thanks a lot!

from mlx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.