magarena / magarena-scripts-builder

Generate card templates from JSON card description

Homepage: http://magarena.github.io

Forum : http://www.slightlymagic.net/forum/viewforum.php?f=82

Requires Java 8 or greater (see Getting Started).

Thanks to

• ubeefx for creating such a great game
• epiko for creating the first Magarena splash screen and the amazing color themes
• Salasnet, pedro1973, and elias for creating beautiful themes, http://www.slightlymagic.net/forum/viewforum.php?f=89
• IcoJoy, http://www.icojoy.com/blogs/, for the nice free mage logo and icon
• singularita for creating the scripts to add over 300 additional creature cards
• glorfindel, Old Nick, David, Grundomu, jeffwadsworth, Kuno, LSK, sponeta,
• day5ive, and Excedrin for contributing premade decks
• mtgrares for the publicity
• Goblin Hero for providing the images for some of the symbols
• Melvin Zhang for implementing the Monte Carlo Tree Search AI and general code cleanup/bug fixes
• IanGrainger for contributing a patch to allow text search in the Card Explorer
• Rachel for making it possible to cancel image download and fixing incorrect images
• beholder for implementing new cards and general usability improvements
• johncpatterson for helping to test the Mac startup script
• wait321 for creating a deck editor and other UI improvements
• missalexis for creating an application bundle to improve Mac installation
• goonjamin for contributing a patch that makes Magarena easier to use on touchscreens
• Lodici for improving the duel screen and general UI enhancements
• frank for extensive play testing and bug reporting
• PalladiaMors, PhazedOut, Aunukia, nado18, Erkcan Özcan, kdesmond, a.
• benedict balbuena, spartan vi, Braullynn, mecheng, pcastellazzi, rasdel,
• Tyrael, hong yie, ember hauler, Hector Marin, drooone, jericho.pumpkin,
• Mike, and Guest for implementing new cards
• ShawnieBoy for implementing new cards, the M logo, and general image enhancements
• PalladiaMors for the Portuguese UI translation
• kannikkiy for the Russian UI translation
• Zac610 for the Italian UI translation
• LoubiTek for the French UI translation
• Pichoro, Acorntail and all at http://magicseteditor.sourceforge.net for CardBuilder components
• XMage for the ArrowBuilder code
• neoedmund for the download images-on-demand implementation
• http://mtgjson.com for card script data
• http://magiccards.info for card images
• http://game-icons.net for UI icons
• http://soundbible.com, http://www.freesound.org for sound effects
• everyone on the CCGHQ forum, http://slightlymagic.net/forum/

Thank you for your support and have fun!

magarena-scripts-builder's Issues

ability word not removed in ability property if it does not occur at start of oracle text

Eg Magarena/scripts_missing/Arbiter_of_the_Ideal.txt

name=Arbiter of the Ideal
image=http://magiccards.info/scans/en/bng/31.jpg
value=2.500
rarity=R
type=Creature
subtype=Sphinx
cost={4}{U}{U}
pt=4/5
ability=Flying;\
        Inspired — Whenever SN becomes untapped, reveal the top card of your library. If it's an artifact, creature, or land card, you may put it onto the battlefield with a manifestation counter on it. That permanent is an enchantment in addition to its other types.
timing=main
oracle=Flying\nInspired — Whenever Arbiter of the Ideal becomes untapped, reveal the top card of your library. If it's an artifact, creature, or land card, you may put it onto the battlefield with a manifestation counter on it. That permanent is an enchantment in addition to its other types.

Move invalidSetCodes into an INPUT file.

https://github.com/magarena/magarena-scripts-builder/blob/master/src/mtgjson/reader/MtgJsonReader.java#L88

generating requires_groovy_code to make use of existing groovy scripts

We have a large set of groovy scripts, most implement a single ability. I'm wondering whether we can leverage on them to further extend the capabilities of scripts-builder by allowing it to generate requires_groovy_code that refer to existing scripts.

The idea is to create an input file with the ability text (as current generated by scripts-builder) and card name (where the groovy script is found). scripts-builder loads this file during scripts generation and check if the ability text matches exactly the one from the file, it will include the card name in the requires_groovy_code property. This way we can get more cards added automatically.

A quick check in release/Magarena/scripts shows 152 cards that reference other cards, seems a bit low. I'm not sure if this effort will be worth it, hence putting it up here for some feedback. Tag @ShawnieBoy

Populate mtginfoSetsMap from an INPUT file.

https://github.com/magarena/magarena-scripts-builder/blob/master/src/mtgjson/reader/MtgJsonReader.java#L237

improve generation of ability property for comma separated abilities

See magarena/magarena@a7e4bea

AllSetsJson requires manual edit after AKH

Nissa, Steward of Elements from AKH is a planeswalker with an X value loyalty. This appears as null in the json and needs to be corrected to "X" to prevent errors