Google Tag Assistant Legacy Error: Number field should not be quoted: 'transactionTotal' , 'transactionTax' and 'transactionShipping' about magento1-google-tag-manager

[olivierognn]

I see the same issue on success page.

adding a float cast to \MagePal_GoogleTagManager_Block_Tm::getOrdersTrackingCode
should fix the error

$transaction = array(
                'transactionId' => $order->getIncrementId(),
                'transactionAffiliation' => Mage::app()->getStore()->getFrontendName(),
                'transactionTotal' => (float)$order->getBaseGrandTotal(),
                'transactionTax' => (float)$order->getBaseTaxAmount(),
                'transactionShipping' => (float)$order->getBaseShippingAmount(),
                'discountCode' => $order->getCouponCode(),
                'discountPrice' => $order->getDiscountAmount(),
                'transactionProducts' => $product
            );

[czamorasoft]

Hey @shashidharkumar and @olivierognn , I think that the error can be solved easily using the JSON Constant "JSON_NUMERIC_CHECK".

In /app/code/local/MagePal/GoogleTagManager/etc/Tm.php on line 84 changed from:

$result[] = sprintf("dataLayer.push(%s);", json_encode($transaction));

to:

$result[] = sprintf("dataLayer.push(%s);", json_encode($transaction, JSON_NUMERIC_CHECK));

Solved 100% to me.

Reference: https://www.php.net/manual/en/json.constants.php

[czamorasoft]

#37