Comments (5)
@alexkoepke .. thanks for the PR.
Is the dataLayer above the tags? See https://developers.google.com/tag-manager/devguide
from magento1-google-tag-manager.
@srenon I see this was resolved for the magento2 version of the extension.
I would be happy to help get this done just not sure on how to do it efficiently. Any help would be much appreciated.
from magento1-google-tag-manager.
I'll fix this shortly
from magento1-google-tag-manager.
@srenon should be fixed :)
from magento1-google-tag-manager.
I have updated the pull request to so the dataLayer and GTM are implemented in the following order.
<!-- Google Data Layer by MagePal--> <script> window.dataLayer = window.dataLayer || []; dataLayer.push({"pageType":"cms_index_index","list":"other","customer":{"isLoggedIn":false},"cart":{"hasItems":false},"ecommerce":{"currencyCode":"USD"}}); </script> <!-- Google Data Layer by MagePal--> <!-- Google Tag Manager by MagePal (head) --> <script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start': new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0], j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src= '//www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f); })(window,document,'script','dataLayer','GTM-XXXXXX');</script> <!-- End Google Tag Manager by MagePal (head) --> <body class=" cms-index-index cms-home"> <!-- Google Tag Manager by MagePal (noscript)--> <noscript><iframe src="//www.googletagmanager.com/ns.html?id=GTM-XXXXX" height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript> <!-- End Google Tag Manager by MagePal noscript)-->
from magento1-google-tag-manager.
Related Issues (20)
- Composer.json requires v1.0.1
- Documentation for installation? HOT 9
- Feature Request: Support the enhanced ecommerce Data Layer format HOT 7
- DataLayer - PageType HOT 2
- DataLayer empty on checkout success HOT 5
- Broken php5 compatibility in DataLayer.php
- Can this work for Magento 1 Onestepcheckout HOT 1
- How are we handling GDPR here? HOT 3
- Feature request: catalog send products list HOT 2
- feature request: how do we handle a sale?
- What is/was the meaning of addCustomVariable HOT 1
- //$this->addVariable('productPrice', $_product->getPrice()); HOT 1
- Pushing and matching configurable transaction data HOT 1
- New version on the horizon HOT 1
- Script Rendering Incorrectly? HOT 1
- Would you mind adding this module to packagist? HOT 1
- How to install the plugin? HOT 3
- Google Tag Assistant Legacy Error: Number field should not be quoted: 'transactionTotal' , 'transactionTax' and 'transactionShipping' HOT 3
- configure event purchase HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magento1-google-tag-manager.