mainmatter / continue-on-error-comment Goto Github PK

This action is designed to be used with PRs to surface the information about which "continue-on-error" jobs have failed.

If someone sets it up to run in a context that doesn't have a PR then it should just fail silently and not break the build 👍

First of all, thank you so much for creating this workflow. Saved my bacon when I tried to integrate some checks that should "warn" on failure and found out GHA simply does not support that usecase.

I found quite an odd problem when integrating this workflow along with trigger-workflow-and-wait though.

If the last commit to a branch that I am PR'ing is a regular commit, github.sha works just fine. But, if the last commit to the branch was a merge or revert commit, then github.sha gives me a nonsensical commit hash

The actual commit that triggered the workflow, a revert commit

Output from continue-on-error-comment

The hash that it links to

I pass this commit hash to my job on the other end of my trigger-workflow-and-wait, and I managed to solve it by using github.event.pull_request.head.sha instead. But continue-on-error-comment still gives me the nonsensical hash when it comments on my PR.

I see that this workflow is using some context.sha to determine the hash, I wonder if this is a similar problem?

Hello again!

I have a special account that my IT org has provisioned for me for CI tasks. This account is not named github-actions[bot] and thus does not delete it's previous comments to the PR that it's running on.

Is it possible to do this check against the user dynamically? Or possibly adding some other metadata (magic string?) to the comment to make this user check unnecessary?

Thanks!

GH warns that Node 16 will be phased out in Spring 2024

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20