manheim / awssume Goto Github PK

Hi,

I love this gem btw. Make my life alot easier. I'm having the following issue when I use aws query parameter and can't seem to find an easy resolutions. Any help would be appreciated

awssume aws --output text lambda list-functions --query 'Functions[?starts_with(FunctionName, `MY_FUNCTION_NAME`) == `true`].FunctionName'


sh: -c: line 0: syntax error near unexpected token `('
sh: -c: line 0: `AWS_ACCESS_KEY_ID='*******' AWS_EXPIRATION='2017-08-16 19:53:49 UTC' AWS_SECRET_ACCESS_KEY='***********' aws --output text lambda list-functions --query Functions[?starts_with(FunctionName, `MY_FUNCTION_NAME`) == `true`].FunctionName'

Currently if awssume is executed with all the configuration it needs but the 'command to execute' returns a non zero exit status, awssume will still return a 0 exit status. This could be problematic for things like Jenkins jobs that pass or fail based on the exit status of the command executed.

https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-core/lib/aws-sdk-core/assume_role_credentials.rb

Could be used in place of the existing assume_role call: https://github.com/manheim/awssume/blob/master/lib/awssume/adapter/aws_client.rb#L14

See: https://github.com/aws/aws-sdk-ruby#supported-services

Looks like awssume only depends on aws-sdk-core but includes the full aws-sdk gem which drastically increases bundle time.

I came from ticket hashicorp/terraform#1275, seems your gem need seperate profile files. I prefer to follow the standard AWS CLI (Command Line Interface) settings to read exist .aws/credentials and .aws/config.

.aws/config supports profile and defines as below:

[profile stag]
region = us-east-2
source_profile = default
role_arn = arn:aws:iam::xxxx:role/CrossAccount

[profile prod]
region = us-east-1
source_profile = default
role_arn = arn:aws:iam::xxxx:role/CrossAccount

Why we need manage two or more aws api key configurations or feed it via command line? Make it simple and no duplication.

source_profile can limit which account to be used.

So we should have something set as below

awssume -profile stag <terraform command>